Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update agent_dev_env with newest recommendations #7498

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

sgnn7
Copy link
Contributor

@sgnn7 sgnn7 commented Feb 22, 2021

What does this PR do?

The old document here has been outdated and did not specify
some very important "gotcha"s that could end up severely
deteriorating the developer experience that are now fixed up.

Motivation

Issues building/running the agent; AC-164

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

N/A

@sgnn7 sgnn7 added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Feb 22, 2021
@sgnn7 sgnn7 added this to the 7.27.0 milestone Feb 22, 2021
@sgnn7 sgnn7 requested a review from a team February 22, 2021 17:03
@sgnn7 sgnn7 requested review from a team as code owners February 22, 2021 17:03
Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Did you have to install gettext in order to build the Agent on Mac OS?

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I left some minor comments

docs/dev/agent_dev_env.md Outdated Show resolved Hide resolved
docs/dev/agent_dev_env.md Outdated Show resolved Hide resolved
docs/dev/agent_dev_env.md Outdated Show resolved Hide resolved
docs/dev/agent_dev_env.md Show resolved Hide resolved
docs/dev/agent_dev_env.md Outdated Show resolved Hide resolved
@sgnn7
Copy link
Contributor Author

sgnn7 commented Feb 22, 2021

Did you have to install gettext in order to build the Agent on Mac OS?

@ogaca-dd I don't remember explicitly installing it but it might have been included in devenv Ansible installation.

@sgnn7 sgnn7 force-pushed the sgnn7/ac-164-improve-agent-dev-env-doc branch 2 times, most recently from bd56e0a to 224f4d2 Compare February 22, 2021 17:35
The old document here has been outdated and did not specify
some very important "gotcha"s that could end up severely
deteriorating the developer experience that are now fixed up.

AC-164
@sgnn7 sgnn7 force-pushed the sgnn7/ac-164-improve-agent-dev-env-doc branch from 224f4d2 to 4f5201a Compare February 22, 2021 17:41
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these updates!!

@sgnn7 sgnn7 merged commit d003b04 into master Feb 23, 2021
@sgnn7 sgnn7 deleted the sgnn7/ac-164-improve-agent-dev-env-doc branch February 23, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants