-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update agent_dev_env
with newest recommendations
#7498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Did you have to install gettext
in order to build the Agent on Mac OS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I left some minor comments
@ogaca-dd I don't remember explicitly installing it but it might have been included in devenv Ansible installation. |
bd56e0a
to
224f4d2
Compare
The old document here has been outdated and did not specify some very important "gotcha"s that could end up severely deteriorating the developer experience that are now fixed up. AC-164
224f4d2
to
4f5201a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for these updates!!
What does this PR do?
The old document here has been outdated and did not specify
some very important "gotcha"s that could end up severely
deteriorating the developer experience that are now fixed up.
Motivation
Issues building/running the agent; AC-164
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
N/A