Get Cloud Foundry application name from Cloud Controller API #7483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
force-pushed
the
hippo/cccache
branch
from
6d62cdf to
b800c12
Compare
zippolyte
force-pushed
the
hippo/cccache
branch
3 times, most recently
from
2b7ccb2 to
0c5a349
Compare
therve
suggested changes
Feb 22, 2021
| @@ -83,7 +83,7 @@ func matchYAMLKey(key string) *regexp.Regexp { | |||
| // matchYAMLKeyEnding returns a regexp matching a single YAML line with a key ending by the string passed as argument. | |||
| // The returned regexp catches only the key and not the value. | |||
| func matchYAMLKeyEnding(ending string) *regexp.Regexp { | |||
| return regexp.MustCompile(fmt.Sprintf(`(\s*(\w|_)*%s\s*:).+`, ending)) | |||
| return regexp.MustCompile(fmt.Sprintf(`(^\s*(\w|_)*%s\s*:).+`, ending)) | |||
There was a problem hiding this comment.
Is that an intended change?
There was a problem hiding this comment.
Yes. Problem was that I can have an error message like failure to get oauth token: err here, which would end up redacted because this function is called with a token ending http://github.com/Datadog/datadog-agent/blob/0c5a349103ba5dc611c2e5b8f85e7c1fb8e9ba3c/pkg/util/log/strip.go#L57-L57.
Since the regex here is intended to match on yaml keys, I figured matching a beginning of line would not cause problems
zippolyte
force-pushed
the
hippo/cccache
branch
from
c64301f to
3d47d5f
Compare
therve
approved these changes
Feb 25, 2021
therve
approved these changes
Feb 25, 2021
hush-hush
requested changes
Mar 1, 2021
hush-hush
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Get a list of applications from the cloud controller API to get up to date names since the BBS API provided one never changes upon renames
Motivation
Useful for people using blue/green deployment scheme for their applications, making heavy use of renaming
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Unit tests and manual tests on lab environment