Include the windows NPM driver in 7.26.x #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeavital
commented
Jan 25, 2021
Comment on lines
+32
to
+35
| "MACOS_BUILD_VERSION": "6.26.0-rc.1", | ||
| "WINDOWS_DDNPM_DRIVER": "attestation-signed", | ||
| "WINDOWS_DDNPM_VERSION": "0.98.2.git.41.c46c971", | ||
| "WINDOWS_DDNPM_SHASUM": "79e641b2078737f6176a50779cb233af6cb2fc86ad6a783c871f1310ff751deb" |
There was a problem hiding this comment.
@derekwbrown to double check these values
|
relnote? |
|
There is a releasenote in the cherry-picked installer changes https://github.com/DataDog/datadog-agent/pull/7246/files#diff-9300bc3ad61e53b680e2a38bc6cb4269637b083900cba72e198dc0236f764673R1 |
derekwbrown
approved these changes
Jan 25, 2021
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title suggests, this release includes network performance monitoring support for windows.
This requires telling the build to include the windows driver.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details that should be tested during the QA.