Fix compiler to match local build

pkg/collector/corechecks/ebpf/c/bcc/oom-kill-kern.c

@@ -1,4 +1,4 @@
-#define KBUILD_MODNAME "foo"
+#define KBUILD_MODNAME "ddsysprobe"
 #include <linux/oom.h>
 
 #include "bpf-common.h"

pkg/collector/corechecks/ebpf/c/bcc/tcp-queue-length-kern.c

@@ -1,5 +1,5 @@
 #include <linux/kconfig.h>
-#define KBUILD_MODNAME "foo"
+#define KBUILD_MODNAME "ddsysprobe"
 #include <linux/bpf.h>
 #include <linux/ptrace.h>
 #include <linux/tcp.h>

pkg/ebpf/compiler/compiler.cpp

@@ -19,11 +19,13 @@ ClangCompiler::ClangCompiler(const char *name) :
     textDiagnosticPrinter(new clang::TextDiagnosticPrinter(errStream, diagOpts.get())),
     diagnosticsEngine(new clang::DiagnosticsEngine(diagID, diagOpts, textDiagnosticPrinter.get(), false)),
     defaultCflags({
-        "-O0", "-O2",
+        "clang", // DO NOT REMOVE, first flag is ignored
+        "-O2",
         "-D__KERNEL__",
         "-fno-color-diagnostics",
         "-fno-unwind-tables",
         "-fno-asynchronous-unwind-tables",
+        "-fno-stack-protector",
         "-x", "c"
     }),
     theTriple("bpf")
@@ -34,7 +36,6 @@ ClangCompiler::ClangCompiler(const char *name) :
         LLVMInitializeBPFTargetInfo();
         LLVMInitializeBPFAsmPrinter();
         LLVMInitializeBPFAsmParser();
-        llvm::InitializeAllTargetMCs();
 
         ClangCompiler::llvmInitialized = true;
     }
@@ -142,7 +143,7 @@ std::unique_ptr<llvm::Module> ClangCompiler::compileToBytecode(
     if (outputFile)
 		invocation->getFrontendOpts().OutputFile = std::string(llvm::StringRef(outputFile));
 
-	invocation->getFrontendOpts().ProgramAction = clang::frontend::EmitBC;
+	invocation->getFrontendOpts().ProgramAction = clang::frontend::EmitLLVM;
 
 	clang::CompilerInstance compiler;
 	compiler.setInvocation(std::move(invocation));
@@ -152,12 +153,12 @@ std::unique_ptr<llvm::Module> ClangCompiler::compileToBytecode(
 		return nullptr;
 	}
 
-	std::unique_ptr<clang::CodeGenAction> emitBCAction(new clang::EmitBCAction(llvmContext.get()));
-	if (!compiler.ExecuteAction(*emitBCAction)) {
+	std::unique_ptr<clang::CodeGenAction> emitLLVMAction(new clang::EmitLLVMAction(llvmContext.get()));
+	if (!compiler.ExecuteAction(*emitLLVMAction)) {
 		return nullptr;
 	}
 
-    return emitBCAction->takeModule();
+    return emitLLVMAction->takeModule();
 }
 
 llvm::StringRef ClangCompiler::getDataLayout()

pkg/ebpf/compiler/compiler.go

@@ -6,7 +6,7 @@ package compiler
 #cgo LDFLAGS: -lclangCodeGen -lclangFrontend -lclangSerialization -lclangDriver -lclangParse -lclangSema -lclangAnalysis -lclangASTMatchers -lclangRewrite -lclangEdit -lclangAST -lclangLex -lclangBasic
 #cgo LDFLAGS: -L/opt/datadog-agent/embedded/lib
 #cgo LDFLAGS: -lLLVMXRay -lLLVMWindowsManifest -lLLVMTableGen -lLLVMSymbolize -lLLVMDebugInfoPDB -lLLVMOrcJIT -lLLVMOrcError -lLLVMJITLink -lLLVMObjectYAML -lLLVMMIRParser -lLLVMMCJIT -lLLVMMCA -lLLVMLTO -lLLVMPasses -lLLVMCoroutines -lLLVMObjCARCOpts -lLLVMipo -lLLVMInstrumentation -lLLVMVectorize -lLLVMLinker -lLLVMIRReader -lLLVMAsmParser -lLLVMFrontendOpenMP -lLLVMExtensions -lLLVMLineEditor -lLLVMLibDriver -lLLVMGlobalISel -lLLVMFuzzMutate -lLLVMInterpreter -lLLVMExecutionEngine -lLLVMRuntimeDyld -lLLVMDWARFLinker -lLLVMDlltoolDriver -lLLVMOption -lLLVMDebugInfoGSYM -lLLVMCoverage -lLLVMCFGuard -lLLVMBPFDisassembler -lLLVMMCDisassembler -lLLVMBPFCodeGen -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMDebugInfoDWARF -lLLVMCodeGen -lLLVMTarget -lLLVMScalarOpts -lLLVMInstCombine -lLLVMAggressiveInstCombine -lLLVMTransformUtils -lLLVMBitWriter -lLLVMAnalysis -lLLVMProfileData -lLLVMObject -lLLVMTextAPI -lLLVMBitReader -lLLVMCore -lLLVMRemarks -lLLVMBitstreamReader -lLLVMBPFAsmParser -lLLVMMCParser -lLLVMBPFDesc -lLLVMMC -lLLVMDebugInfoCodeView -lLLVMDebugInfoMSF -lLLVMBinaryFormat -lLLVMBPFInfo -lLLVMSupport -lLLVMDemangle
-#cgo LDFLAGS: -ldl
+#cgo LDFLAGS: -lz -ldl -ltinfo
 #cgo CPPFLAGS: -I/usr/include -I/opt/datadog-agent/embedded/include -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DLLVM_MAJOR_VERSION=11
 
 #include <stdlib.h>
@@ -73,6 +73,7 @@ func (e *EBPFCompiler) Close() {
 func NewEBPFCompiler(verbose bool) *EBPFCompiler {
 	ebpfCompiler := &EBPFCompiler{
 		compiler: C.new_bpf_compiler(),
+		verbose:  verbose,
 	}
 
 	runtime.SetFinalizer(ebpfCompiler, func(e *EBPFCompiler) {

pkg/network/ebpf/c/prebuilt/offset-guess.c

@@ -29,11 +29,14 @@ struct bpf_map_def SEC("maps/tracer_status") tracer_status = {
 };
 
 static __always_inline bool proc_t_comm_equals(proc_t a, proc_t b) {
-    int i;
-    for (i = 0; i < TASK_COMM_LEN; i++) {
+    for (int i = 0; i < TASK_COMM_LEN; i++) {
         if (a.comm[i] != b.comm[i]) {
             return false;
         }
+        // if chars equal but a NUL terminator, both strings equal
+        if (!a.comm[i]) {
+            break;
+        }
     }
     return true;
 }

tasks/system_probe.py

@@ -347,6 +347,7 @@ def build_object_files(ctx, bundle_ebpf=False):
     print("checking for clang executable...")
     ctx.run("which clang")
     print("found clang")
+    ctx.run("clang -v")
 
     centos_headers_dir = "/usr/src/kernels"
     debian_headers_dir = "/usr/src"
@@ -369,7 +370,7 @@ def build_object_files(ctx, bundle_ebpf=False):
         '-D__KERNEL__',
         '-DCONFIG_64BIT',
         '-D__BPF_TRACING__',
-        '-DKBUILD_MODNAME="\\"foo\\""',
+        '-DKBUILD_MODNAME=ddsysprobe',
         '-Wno-unused-value',
         '-Wno-pointer-sign',
         '-Wno-compare-distinct-pointer-types',
@@ -381,7 +382,10 @@ def build_object_files(ctx, bundle_ebpf=False):
         '-emit-llvm',
         # Some linux distributions enable stack protector by default which is not available on eBPF
         '-fno-stack-protector',
-        "-I{}".format(c_dir),
+        '-fno-color-diagnostics',
+        '-fno-unwind-tables',
+        '-fno-asynchronous-unwind-tables',
+		"-I{}".format(c_dir),
     ]
 
     # Mapping used by the kernel, from https://elixir.bootlin.com/linux/latest/source/scripts/subarch.include