pkg/trace/{agent,stats}: add tag for synthetic data #6955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bmermet
reviewed
Dec 15, 2020
pkg/trace/stats/aggregation.go
Outdated
| @@ -10,6 +10,8 @@ const ( | |||
| tagHostname = "_dd.hostname" | |||
| tagStatusCode = "http.status_code" | |||
| tagVersion = "version" | |||
| tagOrigin = "_dd.origin" | |||
| tagSynthetic = "synthetic" | |||
There was a problem hiding this comment.
Why is the tag called synthetic rather than synthetics like in _dd.origin ?
There was a problem hiding this comment.
That's my mistake. I'll fix it. Thank you!
gbbr
changed the title
|
Please don't merge things during the freeze 🙂 🥶 🤭 |
kristinekunapuli
added a commit
that referenced
this pull request
Dec 16, 2020
This reverts commit b9e978a.
gbbr
pushed a commit
that referenced
this pull request
Dec 16, 2020
kristinekunapuli
added a commit
that referenced
this pull request
Jan 7, 2021
kristinekunapuli
added a commit
that referenced
this pull request
Jan 13, 2021
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
* [apm][stats] add tag for synthetic data * [apm] simplify determining if origin is synthetic data * add release note * fix unit tests * all for client-computed stats to set synthetic tag * change tag to 'synthetics'
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
…6955)" (DataDog#6997) This reverts commit b9e978a.
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
…ataDog#6955)" (DataDog#6997)" (DataDog#7121) This reverts commit 9046ed2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the tag "synthetic:true" when _dd.origin has a value starting with "synthetics". This is to allow independent aggregation of metrics generated from stats payloads.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.