Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better instructions on the README #685

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Provide better instructions on the README #685

merged 3 commits into from
Oct 6, 2017

Conversation

masci
Copy link
Contributor

@masci masci commented Oct 6, 2017

What does this PR do?

Contributors who are not familiar with the concept of GOPATH might have troubles setting up the project, let's make the process better.

Also removed a redundant piece of the PR template for GitHub.

hkaj
hkaj previously approved these changes Oct 6, 2017
README.md Outdated
2. install the project's dependencies: `invoke deps`.
1. checkout the repo: `git clone https://github.com/DataDog/datadog-agent.git $GOPATH/src/github.com/DataDog/datadog-agent`.
2. cd into the project folder: `cd $GOPATH/src/github.com/DataDog/datadog-agent`.
3. install project's dependencies: `invoke deps`.
Make sure that `$GOPATH/bin` is in your `$PATH` otherwise this step might fail.
3. build the whole project with `invoke agent.build --build-exclude=snmp`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 missed that, good catch.

@masci masci merged commit b0bfcd7 into master Oct 6, 2017
@masci masci deleted the massi/readme branch October 6, 2017 14:17
Kyle-Verhoog pushed a commit that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants