Run clang-format and clang-tidy on eBPF code #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycekahle
added
changelog/no-changelog
team/networks
[deprecated] qa/skip-qa - use other qa/ labels
brycekahle
force-pushed
the
bryce.kahle/ebpf-clang-tidy
branch
from
4611dee to
a203291
Compare
|
Don't know why but the tests are failing with: |
brycekahle
force-pushed
the
bryce.kahle/ebpf-clang-tidy
branch
from
e43f6c8 to
e028006
Compare
|
Just a comment: It's not necessary/desirable to tackle this on this PR but we have pre-commit hooks where we could also add this so that people can easily check this client-side https://github.com/DataDog/datadog-agent/blob/master/.pre-commit-config.yaml |
sunhay
reviewed
Nov 6, 2020
brycekahle
force-pushed
the
bryce.kahle/ebpf-clang-tidy
branch
from
e028006 to
5f51963
Compare
brycekahle
force-pushed
the
bryce.kahle/ebpf-clang-tidy
branch
from
5f51963 to
52d62a9
Compare
brycekahle
force-pushed
the
bryce.kahle/ebpf-clang-tidy
branch
from
52d62a9 to
319a8b9
Compare
mx-psi
approved these changes
Mar 3, 2021
lebauce
approved these changes
Mar 4, 2021
brycekahle
force-pushed
the
bryce.kahle/ebpf-clang-tidy
branch
from
6432124 to
eb81743
Compare
hmahmood
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run clang-format and clang-tidy on eBPF code. It runs automatically during the
system-probe.testtarget. Issues do not fail test runs as the moment. This will allow us to gradually fix issues highlighted, rather than forcing all development to stop.Incorporating these checks into a pre-commit hook is ideal, but is complicated by the need to have path-dependent compiler flags. I'm leaving that to a later PR.
Motivation
Ensure ebpf C code is following a consistent style and format.
Additional Notes
We cannot run clang-tidy on the BCC code, since it doesn't compile with
clang.