add entity to jmx config #6595
Merged
add entity to jmx config #6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-mez
approved these changes
Oct 30, 2020
remeh
approved these changes
Oct 30, 2020
truthbk
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Incorporate Entity ID into JMX config to utilize change made in #5409 for JMX checks
Motivation
To have previous change made to prevent check ID clashes apply to JMX checks as well
Additional Notes
Describe your test plan
In a Kubernetes environment, monitor a JMX application pod (via deployment) with the agent JMX check. Delete the application pod and make sure the agent can monitor the new pod without issue.