Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NET_BROADCAST to allowedCaapbilities section #6389

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

gml3ff
Copy link
Contributor

@gml3ff gml3ff commented Sep 16, 2020

What does this PR do?

Existing SCC does not include the NET_BROADCAST capability which is required if you want to use NPM on OpenShift. If this capability is not added, the agent will not deploy at all. See example from a local deployment where I used the Operator:

Without NET_BROADCAST

[morgan.lupton@COMP10906:~/repos/operator-example-with-everything/manifests] (master)$ oc get pods 
NAME                                     READY   STATUS    RESTARTS   AGE
datadog-cluster-agent-64d774fc8d-9mzqs   1/1     Running   0          8m9s

With NET_BROADCAST

[morgan.lupton@COMP10906:~/repos/operator-example-with-everything/manifests] (master)$ oc get pods
NAME                                     READY   STATUS    RESTARTS   AGE
datadog-agent-zvrdd                      4/4     Running   0          20m
datadog-cluster-agent-64d774fc8d-9mzqs   1/1     Running   0          28m

Screenshot of working NPM configuration: https://a.cl.ly/yAub52qg

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@gml3ff gml3ff requested a review from a team as a code owner September 16, 2020 21:01
@bits-bot
Copy link
Collaborator

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gml3ff gml3ff requested a review from vboulineau September 16, 2020 21:10
@gml3ff
Copy link
Contributor Author

gml3ff commented Sep 16, 2020

@clamoriniere Do I need to do anything as far as adding milestones, release notes, and team labels? Looks like those are failing the CircleCI tests.

@clamoriniere clamoriniere added this to the 7.23.0 milestone Sep 18, 2020
@clamoriniere clamoriniere merged commit bd94c2a into master Sep 18, 2020
@clamoriniere clamoriniere deleted the morgan.lupton/add-netbroadcast-scc branch September 18, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants