[system-probe] Add stats for DNS successes, errors, and queries #6130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeavital
reviewed
Aug 4, 2020
pkg/ebpf/bytecode/tracer-ebpf.go
Outdated
| @@ -755,7 +755,7 @@ func bindataPkgEbpfCTracerebpfdebugo() (*asset, error) { | |||
| name: "pkg/ebpf/c/tracer-ebpf-debug.o", | |||
| size: 59848, | |||
| md5checksum: "", | |||
| mode: os.FileMode(436), | |||
| mode: os.FileMode(420), | |||
There was a problem hiding this comment.
FYI we're going to stop embedding the binaries inside the executable, so these changes should stop appearing
The stats are based on what is done on the snooper side - so it includes all DNS queries/responses irrespective of whether we can associate them with a connection or not. |
leeavital
approved these changes
Aug 4, 2020
leeavital
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds stats for
No explicit count for
Timeouts. It should be1 - (2 + 3)Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.