Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AI review by Codex (OpenAI) - workflow run
The patch is correct. The telemetry sender, exported callbacks, WiX actions, and obsolete tests are removed consistently, with no remaining references found. Shared HTTP support and installation actions remain intact. Windows MSI build and runtime tests were not independently run during this review.
Contributor
clarkb7
added
the
qa/done
Contributor
Files inventory check summaryFile checks results against ancestor c2a701c6: Results for datadog-agent_7.86.0~devel.git.326.69820b0.pipeline.143783696-1_amd64.deb:No change detected Results for datadog-iot-agent_7.86.0~devel.git.326.69820b0.pipeline.143783696-1_amd64.deb:No change detected |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the Windows Agent MSI success and rollback callbacks that sent
apm-onboarding-eventtelemetry, along with their exported entry points, dedicated sender, and obsolete unit tests.Motivation
The intake was deactivated over a year ago (WINA-2832, backend removal), so these installer callbacks no longer serve their original purpose.
Describe how you validated your changes
existing E2E tests validate MSI behavior
Additional Notes
Removal from agent-linux-install-script remains separate follow-up work. The PowerShell installer and its build/signing/deployment jobs were already removed in commit
5d48a22a650.