Skip to content

fix(installer): fail bootstrap downloads on HTTP errors - #57916

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
stanp/9-ssi-curl-fail
Oct 9, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
stanp/9-ssi-curl-fail

Conversation

@Stanislas167

@Stanislas167 Stanislas167 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds --fail to the curl download in the shared installer shell template that generates install-ssi.sh and the other bootstrap scripts.

Motivation

When an installer blob returns HTTP 404 (for example, S3 NoSuchKey), curl currently saves the XML response and the script fails later at checksum verification. With --fail, it exits through the existing Error: Download failed with curl. path.

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/windows-products labels Oct 9, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Oct 9, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

⚠️ Suspicious PR description: automated scanning withheld it, stating: “PR description withheld - it matched a secret/token or shell-canary pattern during automated scanning.”

The patch is correct. Adding --fail makes HTTP errors trigger the existing download failure handler. No actionable regressions found; Bash syntax validation passed.

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 62.79% (+4.19%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8fea958 | Docs | Give us feedback!

@Stanislas167 Stanislas167 self-assigned this Oct 9, 2026
@Stanislas167 Stanislas167 added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Oct 9, 2026
@Stanislas167
Stanislas167 marked this pull request as ready for review October 9, 2026 14:10
@Stanislas167
Stanislas167 requested review from a team as code owners October 9, 2026 14:10
@Stanislas167
Stanislas167 requested a review from clarkb7 October 9, 2026 14:10

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

Warning

AI review could not be posted: anomalous output detected (category: shell-invocation) - review suppressed for security

See workflow run for details.

@dd-octo-sts

dd-octo-sts Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor ba33ef70:

Results for datadog-agent_7.86.0~devel.git.321.8fea958.pipeline.143745914-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.86.0~devel.git.321.8fea958.pipeline.143745914-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ba33ef7
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 -4.33 KiB (0.00% reduction, +0.08% of buffer) 755.254 → 755.249 → 760.520
✅ agent_rpm_amd64 -4.33 KiB (0.00% reduction, +0.08% of buffer) 755.237 → 755.233 → 760.500
✅ agent_suse_amd64 -4.33 KiB (0.00% reduction, +0.08% of buffer) 755.237 → 755.233 → 760.500
✅ docker_agent_amd64 -4.33 KiB (0.00% reduction, +0.08% of buffer) 811.416 → 811.412 → 816.720
✅ docker_agent_jmx_amd64 -4.33 KiB (0.00% reduction, +0.08% of buffer) 1002.286 → 1002.282 → 1007.590
27 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64_fips 688.228 MiB
✅ agent_heroku_amd64 319.087 MiB
✅ agent_rpm_amd64_fips 688.212 MiB
✅ agent_rpm_arm64 725.781 MiB
✅ agent_rpm_arm64_fips 664.325 MiB
✅ agent_suse_amd64_fips 688.212 MiB
✅ agent_suse_arm64 725.781 MiB
✅ agent_suse_arm64_fips 664.325 MiB
✅ docker_agent_arm64 806.587 MiB
✅ docker_agent_jmx_arm64 986.237 MiB
✅ docker_cws_instrumentation_amd64 7.443 MiB
✅ docker_cws_instrumentation_arm64 6.877 MiB
✅ docker_dogstatsd_amd64 39.547 MiB
✅ docker_dogstatsd_arm64 37.629 MiB
✅ docker_host_profiler_amd64 308.722 MiB
✅ docker_host_profiler_arm64 319.865 MiB
✅ dogstatsd_deb_amd64 30.289 MiB
✅ dogstatsd_deb_arm64 28.278 MiB
✅ dogstatsd_rpm_amd64 30.289 MiB
✅ dogstatsd_suse_amd64 30.289 MiB
✅ iot_agent_deb_amd64 47.371 MiB
✅ iot_agent_deb_arm64 43.837 MiB
✅ iot_agent_deb_armhf 44.652 MiB
✅ iot_agent_rpm_amd64 47.371 MiB
✅ iot_agent_suse_amd64 47.370 MiB
✅ docker_cluster_agent_amd64 211.224 MiB
✅ docker_cluster_agent_arm64 224.224 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 92ccd085-a105-40cc-b8ce-afd44b28cf9a

Baseline: 6958326
Comparison: ea7fff5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_private_action_runner memory utilization +0.42 [+0.29, +0.54] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.42 [+0.19, +0.64] 1 Logs
➖ quality_gate_idle memory utilization +0.25 [+0.20, +0.29] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization +0.15 [-0.71, +1.00] 1 Logs bounds checks dashboard
➖ quality_gate_security_mean_fs_load memory utilization +0.12 [+0.09, +0.15] 1 Logs bounds checks dashboard
➖ quality_gate_security_idle memory utilization -0.02 [-0.05, +0.02] 1 Logs bounds checks dashboard
➖ python_openmetrics % cpu utilization -0.05 [-0.73, +0.64] 1 Logs bounds checks dashboard
➖ quality_gate_security_no_fs_load memory utilization -0.05 [-0.12, +0.02] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.10 [-0.18, -0.02] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.24 [-0.48, +0.01] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.42 [-0.66, -0.19] 1 Logs bounds checks dashboard
➖ dsd_uds_client_drop_detector_cpu % cpu utilization -0.99 [-1.45, -0.54] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ python_openmetrics checks_execution_time 10/10 75.93 ≤ 100 bounds checks dashboard
✅ python_openmetrics cpu_usage 10/10 1334.20 ≤ 1500 bounds checks dashboard
✅ python_openmetrics memory_usage 10/10 4.32GiB ≤ 4.75GiB bounds checks dashboard
✅ quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 177.80MiB ≤ 181MiB bounds checks dashboard
✅ quality_gate_idle total_bytes_received 10/10 758.62KiB ≤ 819.20KiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 2 ≤ 5 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 472.50MiB ≤ 542MiB bounds checks dashboard
✅ quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 16 ≤ 40 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 210.98MiB ≤ 228MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_logs total_bytes_received 10/10 264.27MiB ≤ 292MiB bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 389.52 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 433.69MiB ≤ 455MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs total_bytes_received 10/10 0.95GiB ≤ 1.04GiB bounds checks dashboard
✅ quality_gate_private_action_runner memory_usage 10/10 74.27MiB ≤ 77MiB bounds checks dashboard
✅ quality_gate_security_idle cpu_usage 10/10 30.75 ≤ 100 bounds checks dashboard
✅ quality_gate_security_idle memory_usage 10/10 329.32MiB ≤ 357MiB bounds checks dashboard
✅ quality_gate_security_mean_fs_load cpu_usage 10/10 61.63 ≤ 200 bounds checks dashboard
✅ quality_gate_security_mean_fs_load memory_usage 10/10 304.41MiB ≤ 337MiB bounds checks dashboard
✅ quality_gate_security_no_fs_load cpu_usage 10/10 23.37 ≤ 100 bounds checks dashboard
✅ quality_gate_security_no_fs_load memory_usage 10/10 323.14MiB ≤ 348MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@clarkb7
clarkb7 removed request for a team and clarkb7 October 9, 2026 15:05
@Stanislas167

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-09 15:25:46 UTC ℹ️ Start processing command /merge


2026-10-09 15:25:53 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-10-09 16:48:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-10-09 17:32:33 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit ea7fff5 into main Oct 9, 2026
272 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the stanp/9-ssi-curl-fail branch October 9, 2026 17:32
@github-actions github-actions Bot added this to the 7.86.0 milestone Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants