Skip to content

Wire Jev skipping behing a feature flag + some cleanup - #57900

Draft
KevinFairise2 wants to merge 7 commits into
mainfrom
kfairise/wire-jev-behind-feature-flag
Draft

KevinFairise2 wants to merge 7 commits into
mainfrom
kfairise/wire-jev-behind-feature-flag

Conversation

@KevinFairise2

Copy link
Copy Markdown
Member

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-devx labels Oct 9, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Oct 9, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

The patch is incorrect: removing the pipeline SHA check allows Jev evaluation to compare predictions from one commit against test results from another, producing misleading evaluation telemetry.

Comment thread tasks/dyntest.py Outdated
Comment on lines +135 to +138
# A plain DynTestExecutor with a static index (committed in Git, where
# the coverage executors keep theirs in S3). The shared evaluator owns
# the CI Visibility queries; the executor's GitLab jobs fetch
# supplies the allow-failure set.
executor = JevDynTestExecutor(ctx, commit_sha, pipeline_id, require_pipeline_commit=not ignore_sha_mismatch)
# the CI Visibility queries.
executor = JevDynTestExecutor(ctx, commit_sha)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Preserve the evaluated pipeline's commit check

The remaining check only compares commit_sha with local HEAD; it never verifies that pipeline_id ran that commit. With --commit-sha omitted, any pipeline now passes validation, so Jev computes predictions from the current checkout's diff and compares them against an unrelated pipeline's results, potentially publishing bogus misses and selection statistics. Keep the pipeline SHA validation in the evaluation task when removing it from the executor used for live selection.

@datadog-official

datadog-official Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 62.79% (+4.20%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c117417 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor fa3e131b:

Results for datadog-agent_7.86.0~devel.git.309.c117417.pipeline.143774466-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.86.0~devel.git.309.c117417.pipeline.143774466-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fa3e131
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 755.264 MiB
✅ agent_deb_amd64_fips 688.274 MiB
✅ agent_heroku_amd64 319.144 MiB
✅ agent_msi 653.830 MiB
✅ agent_rpm_amd64 755.247 MiB
✅ agent_rpm_amd64_fips 688.258 MiB
✅ agent_rpm_arm64 725.784 MiB
✅ agent_rpm_arm64_fips 664.367 MiB
✅ agent_suse_amd64 755.247 MiB
✅ agent_suse_amd64_fips 688.258 MiB
✅ agent_suse_arm64 725.784 MiB
✅ agent_suse_arm64_fips 664.367 MiB
✅ docker_agent_amd64 811.427 MiB
✅ docker_agent_arm64 806.590 MiB
✅ docker_agent_jmx_amd64 1002.296 MiB
✅ docker_agent_jmx_arm64 986.240 MiB
✅ docker_cws_instrumentation_amd64 7.443 MiB
✅ docker_cws_instrumentation_arm64 6.877 MiB
✅ docker_dogstatsd_amd64 39.551 MiB
✅ docker_dogstatsd_arm64 37.629 MiB
✅ docker_host_profiler_amd64 308.722 MiB
✅ docker_host_profiler_arm64 319.864 MiB
✅ dogstatsd_deb_amd64 30.293 MiB
✅ dogstatsd_deb_arm64 28.278 MiB
✅ dogstatsd_rpm_amd64 30.293 MiB
✅ dogstatsd_suse_amd64 30.293 MiB
✅ iot_agent_deb_amd64 47.371 MiB
✅ iot_agent_deb_arm64 43.837 MiB
✅ iot_agent_deb_armhf 44.652 MiB
✅ iot_agent_rpm_amd64 47.371 MiB
✅ iot_agent_suse_amd64 47.370 MiB
✅ docker_cluster_agent_amd64 211.196 MiB
✅ docker_cluster_agent_arm64 224.224 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 004286a0-3a2c-45bd-8b6f-f7eafb09688f

Baseline: fa3e131
Comparison: c117417
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_metrics_logs memory utilization +1.35 [+1.13, +1.57] 1 Logs bounds checks dashboard
➖ dsd_uds_client_drop_detector_cpu % cpu utilization +0.28 [-0.22, +0.78] 1 Logs
➖ python_openmetrics % cpu utilization +0.26 [-0.42, +0.94] 1 Logs bounds checks dashboard
➖ quality_gate_security_mean_fs_load memory utilization +0.05 [+0.02, +0.09] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.03 [-0.08, +0.01] 1 Logs bounds checks dashboard
➖ quality_gate_security_no_fs_load memory utilization -0.09 [-0.16, -0.03] 1 Logs bounds checks dashboard
➖ quality_gate_private_action_runner memory utilization -0.14 [-0.26, -0.01] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -0.27 [-1.14, +0.59] 1 Logs bounds checks dashboard
➖ quality_gate_security_idle memory utilization -0.35 [-0.39, -0.32] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.39 [-0.47, -0.31] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -0.72 [-0.93, -0.50] 1 Logs
➖ dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -1.77 [-2.01, -1.53] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ python_openmetrics checks_execution_time 10/10 81.72 ≤ 100 bounds checks dashboard
✅ python_openmetrics cpu_usage 10/10 1335.64 ≤ 1500 bounds checks dashboard
✅ python_openmetrics memory_usage 10/10 4.32GiB ≤ 4.75GiB bounds checks dashboard
✅ quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 177.75MiB ≤ 181MiB bounds checks dashboard
✅ quality_gate_idle total_bytes_received 10/10 765.33KiB ≤ 819.20KiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 2 ≤ 5 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 471.14MiB ≤ 542MiB bounds checks dashboard
✅ quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 212.40MiB ≤ 228MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_logs total_bytes_received 10/10 263.91MiB ≤ 292MiB bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 377.47 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 415.82MiB ≤ 455MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs total_bytes_received 10/10 0.95GiB ≤ 1.04GiB bounds checks dashboard
✅ quality_gate_private_action_runner memory_usage 10/10 73.57MiB ≤ 77MiB bounds checks dashboard
✅ quality_gate_security_idle cpu_usage 10/10 31.68 ≤ 100 bounds checks dashboard
✅ quality_gate_security_idle memory_usage 10/10 327.39MiB ≤ 357MiB bounds checks dashboard
✅ quality_gate_security_mean_fs_load cpu_usage 10/10 63.87 ≤ 200 bounds checks dashboard
✅ quality_gate_security_mean_fs_load memory_usage 10/10 307.84MiB ≤ 337MiB bounds checks dashboard
✅ quality_gate_security_no_fs_load cpu_usage 10/10 25.66 ≤ 100 bounds checks dashboard
✅ quality_gate_security_no_fs_load memory_usage 10/10 335.29MiB ≤ 348MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-octo-sts

dd-octo-sts Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 336 0 0

ℹ️ Diff available in the job log.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time team/agent-build team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant