Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Chocolatey be installed on Domain Controllers #5648

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

julien-lebot
Copy link
Contributor

What does this PR do?

Remove early bail out if installing chocolatey on domain controller.

Motivation

Since the user can pass parameters to the MSI via install arguments (https://chocolatey.org/docs/commandsinstall) it makes sense to let it be installed on Domain Controller.

@julien-lebot julien-lebot added this to the 7.21.0 milestone May 29, 2020
@julien-lebot julien-lebot requested a review from derekwbrown May 29, 2020 14:23
@julien-lebot julien-lebot requested a review from a team as a code owner May 29, 2020 14:23
Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do another RC, let's backport this.

@albertvaka albertvaka merged commit 5149987 into master Jun 2, 2020
@albertvaka albertvaka deleted the julien.lebot/choco_on_dc branch June 2, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants