Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Windows Containers to Windows Server Nano #5488

Merged
merged 4 commits into from
May 12, 2020

Conversation

albertvaka
Copy link
Contributor

What does this PR do?

Use Nano as a base image.

Motivation

Process Agent was fixed to work on Nano in #5341

Process Agent was fixed to work on Nano in #5341
Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the base images are correct, see https://hub.docker.com/_/microsoft-powershell

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Julien Lebot <julien.lebot@datadoghq.com>
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
julien-lebot
julien-lebot previously approved these changes May 12, 2020
vboulineau
vboulineau previously approved these changes May 12, 2020
@albertvaka albertvaka dismissed stale reviews from vboulineau and julien-lebot via e5360bb May 12, 2020 13:09
@albertvaka albertvaka merged commit e0d5c44 into master May 12, 2020
@albertvaka albertvaka deleted the albertvaka/containerized-windows-nano branch May 12, 2020 18:13
albertvaka added a commit that referenced this pull request May 21, 2020
albertvaka added a commit that referenced this pull request May 25, 2020
)

psutil doesn't support Windows Nano yet so many checks that use it won't work.

This reverts commit e0d5c44.
julien-lebot added a commit that referenced this pull request Jul 6, 2020
julien-lebot added a commit that referenced this pull request Aug 20, 2020
julien-lebot added a commit that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants