[gitlab] Fix go.mod consistency check #5475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
added
[deprecated] team/agent-core
olivielpeau
force-pushed
the
olivielpeau/go-mod-check
branch
from
a058a6a to
9d48462
Compare
leeavital
approved these changes
May 6, 2020
clamoriniere
approved these changes
May 6, 2020
albertvaka
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the go.mod consistency check so that it actually checks the consistency of
go.modagainst the project imports.Motivation
Avoid inconsistencies between project imports and go.mod file, as noticed on #5447 (which removed a couple of packages from
go.modthat weren't related to PR changes)Additional Notes
See https://tip.golang.org/cmd/go/#hdr-Maintaining_module_requirements
Testing
The check fails on the commit of the PR (because it doesn't include #5447).
With master (which now includes #5447) merged into this PR, the check should pass.