Add multi mode chocolatey installation modes (online & offline) #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch chocolatey to online install by default Offline installer is only built on demand
albertvaka
previously approved these changes
Apr 28, 2020
| $installMethod = "online" | ||
| $nuspecFile = c:\mnt\chocolatey\datadog-agent-online.nuspec | ||
| $nupkgs = Get-ChildItem c:\mnt\chocolatey\datadog-agent*.msi | ||
| if (($nupkgs | Measure-Object).Count -gt 0) { |
There was a problem hiding this comment.
We could have three cases here:
count == 0: offlinecount == 1: onlinecount > 1: error, abort
albertvaka
previously approved these changes
Apr 28, 2020
albertvaka
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new 'online' installer for the Chocolatey package that will download the agent, instead of bundling the MSI with it.
Motivation
We have some issue pushing offline packages to Chocolatey's servers, so for now it's use the smaller 'online' package.
Additional Notes
Online package is built by default, offline installer is only built on demand.
Publish job can publish multiple packages.
/!\ The offline package has the ID
datadog-agent-offlinethat is different from the online packagedatadog-agent.