Build systemd for all Linuxes #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
changed the title
KSerrania
reviewed
Apr 22, 2020
Comment on lines
-96
to
-116
| def get_distro_exclude_tags(): | ||
| """ | ||
| Get tags that should be excluded for current distro. | ||
| """ | ||
| distro_name = distro.id().lower() | ||
| exclude = [] | ||
| if distro_name not in REDHAT_DEBIAN_SUSE_DIST: | ||
| exclude.extend(REDHAT_DEBIAN_SUSE_ONLY_TAGS) | ||
| return exclude | ||
|
|
||
|
|
There was a problem hiding this comment.
I think this means we're not using distro anymore anywhere (I only see it imported but not used in this file & the tasks/android.py file). We may be able to get rid of this dependency then.
albertvaka
force-pushed
the
albertvaka/systemd-everywhere
branch
from
a44668d to
a377fbc
Compare
KSerrania
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the systemd build tag for all Linux distros.
Motivation
Most Linux distros have adopted systemd.