Fix ENV vars propagation to services and start of process-agent service in Windows containers #5365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwbrown
reviewed
Apr 17, 2020
| if found { | ||
| overrideVars["process_config.enabled"] = ddProcessAgentEnabled | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this can be done with simple config.BindEnv(), yes?
There was a problem hiding this comment.
No because the variable name is not the same. Using BindEnv would generate DD_PROCESS_CONFIG_ENABLED variable.
clamoriniere
previously approved these changes
Apr 20, 2020
julien-lebot
previously approved these changes
Apr 20, 2020
vboulineau
dismissed stale reviews from julien-lebot and clamoriniere
via
e3876f1
vboulineau
force-pushed
the
vboulineau/win_docker_services
branch
from
ae9e753 to
e3876f1
Compare
julien-lebot
previously approved these changes
Apr 20, 2020
…ce in Windows containers
vboulineau
force-pushed
the
vboulineau/win_docker_services
branch
from
e3876f1 to
21e91af
Compare
julien-lebot
approved these changes
Apr 20, 2020
clamoriniere
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently ENV vars are set by Docker at process level, which does not allow background services to read them.
Read
DD_PROCESS_AGENT_ENABLEDin Core agent to know if we should start the process-agent service.