[docs] Add inline deprecation comment about StandardJMXIntegrations #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
added
[deprecated] team/agent-core
ofek
approved these changes
Apr 14, 2020
prognant
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds inline deprecation comment about StandardJMXIntegrations
Motivation
We should only keep this list for backward compatibility with older existing configs, and define
is_jmx: truein our JMXFetch integration configs instead (already done at the moment)Additional Notes
In the future, we may want to report deprecation warning when this list is actually used for a config, and remove the list altogether in a future major version. Adding that to our backlog.