Skip to content

fix(serverless-init): restrict lifecycle hook routes to POST method#52741

Open
litianningdatadog wants to merge 1 commit into
tianning.li/15-move-arch-check-into-microvmfrom
tianning.li/16-restrict-lifecycle-hooks-to-post
Open

fix(serverless-init): restrict lifecycle hook routes to POST method#52741
litianningdatadog wants to merge 1 commit into
tianning.li/15-move-arch-check-into-microvmfrom
tianning.li/16-restrict-lifecycle-hooks-to-post

Conversation

@litianningdatadog

@litianningdatadog litianningdatadog commented Jun 24, 2026

Copy link
Copy Markdown

Summary

  • Registers all MicroVM lifecycle hook paths with `"POST "` prefix so `ServeMux` returns `405 Method Not Allowed` for non-POST requests (previously accepted any HTTP method)
  • Introduces named `post*` constants (`postReady`, `postLaunch`, etc.) following the existing `path*` constant pattern — no runtime string concatenation
  • Removes MicroVM-specific inline comments from `main.go` per reviewer feedback ("no need to include this commentary here")
  • Adds `TestRoutes_NonPost_Returns405` to pin the 405 contract

Addresses reviewer feedback on PR #2.

Test plan

  • `TestRoutes` (existing) — POST requests to all routes still return 200
  • `TestRoutes_NonPost_Returns405` (new) — GET requests to all routes return 405

🤖 Generated with Claude Code


🔁 Mirror of internal PR: https://github.com/DataDog/datadog-agent-internal/pull/27

Register all MicroVM lifecycle hook paths with "POST " prefix so
ServeMux returns 405 Method Not Allowed for non-POST requests.
Adds a named constant for each post-prefixed route (postReady,
postLaunch, etc.) following the existing path constant pattern.
Adds TestRoutes_NonPost_Returns405 to pin the 405 contract.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@litianningdatadog litianningdatadog requested a review from a team as a code owner June 24, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@datadog-prod-us1-6

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor de36884b:

Results for datadog-agent_7.82.0~devel.git.355.54ab9bc.pipeline.120862196-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor de36884
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +2.31 KiB (0.00% increase, -0.02% of buffer) 747.693 → 747.696 → 758.200
agent_deb_amd64_fips +6.31 KiB (0.00% increase, -0.10% of buffer) 703.639 → 703.645 → 709.840
agent_rpm_amd64 +2.31 KiB (0.00% increase, -0.02% of buffer) 747.677 → 747.679 → 758.170
agent_rpm_amd64_fips +6.31 KiB (0.00% increase, -0.10% of buffer) 703.623 → 703.629 → 709.840
agent_suse_amd64 +2.31 KiB (0.00% increase, -0.02% of buffer) 747.677 → 747.679 → 758.170
agent_suse_amd64_fips +6.31 KiB (0.00% increase, -0.10% of buffer) 703.623 → 703.629 → 709.840
docker_agent_amd64 +2.31 KiB (0.00% increase, -0.03% of buffer) 806.512 → 806.514 → 813.790
docker_agent_jmx_amd64 +2.31 KiB (0.00% increase, -0.03% of buffer) 997.409 → 997.411 → 1004.550
24 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 308.657 MiB
agent_rpm_arm64 723.234 MiB
agent_rpm_arm64_fips 682.787 MiB
agent_suse_arm64 723.234 MiB
agent_suse_arm64_fips 682.787 MiB
docker_agent_arm64 807.085 MiB
docker_agent_jmx_arm64 986.635 MiB
docker_cluster_agent_amd64 208.068 MiB
docker_cluster_agent_arm64 221.314 MiB
docker_cws_instrumentation_amd64 7.447 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.012 MiB
docker_dogstatsd_arm64 37.117 MiB
docker_host_profiler_amd64 305.017 MiB
docker_host_profiler_arm64 316.112 MiB
dogstatsd_deb_amd64 29.747 MiB
dogstatsd_deb_arm64 27.802 MiB
dogstatsd_rpm_amd64 29.747 MiB
dogstatsd_suse_amd64 29.747 MiB
iot_agent_deb_amd64 45.676 MiB
iot_agent_deb_arm64 42.390 MiB
iot_agent_deb_armhf 43.176 MiB
iot_agent_rpm_amd64 45.676 MiB
iot_agent_suse_amd64 45.675 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: db202d38-4e81-4984-94ed-4d8e0dc03486

Baseline: de36884
Comparison: 54ab9bc
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • quality_gate_idle_all_features

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.21 [+0.97, +1.46] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +1.15 [+0.06, +2.24] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.47 [+0.41, +0.52] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.20 [+0.16, +0.24] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.20 [+0.15, +0.25] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.17 [+0.12, +0.21] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.04 [-0.05, +0.13] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 147.17MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 579.40KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 487.03MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 0.89MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 180.06MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.19MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 374.19 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 395.08MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.86GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 31.27 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 296.21MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 59.11 ≤ 80 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 277.52MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 24.91 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 279.54MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features comparison 7 Oom killed Debug Dashboard

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant