Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix omnibus env vars convention #5264

Merged
merged 2 commits into from
May 12, 2020
Merged

Fix omnibus env vars convention #5264

merged 2 commits into from
May 12, 2020

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Apr 3, 2020

What does this PR do?

Fix the way the WITH_BCC omnibus env vars is checked to align with the convention followed by similar env vars.

Motivation

Suggestion from #4619.

Additional Notes

@L3n41c L3n41c added this to the 7.20.0 milestone Apr 3, 2020
@L3n41c L3n41c requested a review from olivielpeau April 3, 2020 19:52
@L3n41c L3n41c requested a review from a team as a code owner April 3, 2020 19:52
@L3n41c L3n41c mentioned this pull request Apr 3, 2020
Merged
olivielpeau
olivielpeau approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing!

@L3n41c L3n41c merged commit 37924d8 into master May 12, 2020
@L3n41c L3n41c deleted the lenaic/cosmetics branch May 12, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog team/containers
Projects
None yet
Milestone
7.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@L3n41c @olivielpeau