[tasks] stop the build if GO111MODULE is set to on. #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remeh
added
[deprecated] team/agent-core
remeh
force-pushed
the
remeh/invoke-go111module
branch
from
ac2e968 to
c266667
Compare
olivielpeau
reviewed
Feb 26, 2020
Co-Authored-By: Olivier Vielpeau <olivielpeau@users.noreply.github.com>
…-agent into remeh/invoke-go111module
albertvaka
reviewed
Mar 9, 2020
olivielpeau
reviewed
Mar 9, 2020
Co-Authored-By: Olivier Vielpeau <olivielpeau@users.noreply.github.com>
Co-Authored-By: Olivier Vielpeau <olivielpeau@users.noreply.github.com>
albertvaka
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a step in all builds task to stop the build if
GO111MODULEis set toon.Motivation
The datadog-agent is not using the Go modules yet. The default behavior of the Go modules while compiling the Agent in a GOPATH is fine (it's not using the Go modules because we're in a GOPATH and there is no go.mod file available), however, if GO111MODULE has been forced to on in the user environment, the build would fail.