Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some documentation for building with onmnibus on Windows #4556

Merged
merged 2 commits into from
Dec 25, 2019
Merged

Added some documentation for building with onmnibus on Windows #4556

merged 2 commits into from
Dec 25, 2019

Conversation

julien-lebot
Copy link
Contributor

What does this PR do?

Add documentation on how to build the Agent on Windows

Motivation

There was no documentation on our Wiki (TODO.)

Additional Notes

Anything else we should know when reviewing?

@julien-lebot julien-lebot added this to the 7.17.0 milestone Dec 5, 2019
@julien-lebot julien-lebot requested review from a team as code owners December 5, 2019 10:50
albertvaka
albertvaka reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have this in the docs. Asking for reviews from people who actually build on windows, though :)

@apigirl apigirl added the editorial review Waiting on a more in-depth review from a docs team editor label Dec 5, 2019
cswatt
cswatt reviewed Dec 17, 2019
View reviewed changes
docs/dev/agent_omnibus.md Outdated Show resolved Hide resolved
@julien-lebot @cswatt
Formatting
8cd5910 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@julien-lebot julien-lebot mentioned this pull request Dec 24, 2019
Merged
ofek
ofek approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd just make our Windows builder Docker image public and recommend that. I will never not use that as this manual way is too painful.

@julien-lebot julien-lebot merged commit a6c7fa9 into master Dec 25, 2019
@julien-lebot julien-lebot deleted the julien.lebot/add_omnibus_windows_documentation branch December 25, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt left review comments

@albertvaka albertvaka albertvaka approved these changes

@ofek ofek ofek approved these changes

@derekwbrown derekwbrown Awaiting requested review from derekwbrown

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] team/agent-platform documentation editorial review Waiting on a more in-depth review from a docs team editor
Projects
None yet
Milestone
7.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@julien-lebot @albertvaka @cswatt @ofek @apigirl