[rtloader] Fix small mem leak in set_external_tags #4360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only happens when an empty dict is passed for a given hostname. Added test that demonstrates the leak.
olivielpeau
added
[deprecated] team/agent-core
truthbk
approved these changes
Oct 22, 2019
| @@ -384,6 +384,29 @@ func TestSetExternalTagInvalidTagsList(t *testing.T) { | |||
| helpers.AssertMemoryUsage(t) | |||
| } | |||
|
|
|||
| func TestSetExternalTagEmptyDict(t *testing.T) { | |||
julien-lebot
approved these changes
Nov 5, 2019
xlucas
pushed a commit
that referenced
this pull request
Nov 18, 2019
Only happens when an empty dict is passed for a given hostname. Added test that demonstrates the leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix small mem leak in
set_external_tags. Only happens when an empty dict is passed for a given hostname.Added test that demonstrates the leak.
Motivation
💅
Additional Notes
Was easy to find and fix thanks to the very useful mem tracking facilities that were added in #4134!