Improve three::_findSubclassOf resiliency based on two's code. #3990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remeh
added
[deprecated] team/agent-core
remeh
commented
Aug 8, 2019
| klass = PyObject_GetAttrString(module, symbol_name); | ||
| ::free(symbol_name); | ||
| if (klass == NULL) { | ||
| PyErr_Clear(); |
There was a problem hiding this comment.
I think it's not required due to as_string implementation, but it doesn't harm and better mimics the two code.
hush-hush
previously approved these changes
Aug 15, 2019
hush-hush
force-pushed
the
remeh/py3_subclassof
branch
from
7c07f7a to
1b6a7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mimics the
two::_findSubclassOfbehavior inthree::_findSubclassOfbecause thetwo's implementation has been well tested since and the changes were not reflected on thethree's implementation.Motivation
The original goal is to improve the resiliency of
_findSubclassOfin thethreeimplementation.It should not have any impact and it doesn't have any logic change, just code clarity.
Additional Notes
Ref PR: #3487