Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak docs to make Dockerized build more visible #3875

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

albertvaka
Copy link
Contributor

Motivation

We made our builder images open source again, so we want to recommend using them.

@albertvaka albertvaka added documentation [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog team/baklava labels Jul 15, 2019
@albertvaka albertvaka added this to the 6.14.0 milestone Jul 15, 2019
@albertvaka albertvaka requested review from a team as code owners July 15, 2019 10:10
Copy link
Collaborator

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few nits 👍

docs/dev/agent_omnibus.md Outdated Show resolved Hide resolved
If the build images crash when you run them on modern Linux distributions, you might be
affected by [this bug](https://github.com/moby/moby/issues/28705).

## Building on your system (Linux and Mac)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here the requirements part of the Prepare the dev environment section that was removed, since you do need these to run Omnibus locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need python and pip, clang, systemd headers, and a ton of other dependencies... I found the list so incomplete I thought it was better to remove it.

Co-Authored-By: Kylian Serrania <kylian.serrania@datadoghq.com>
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small grammar suggestions from the docs team

docs/dev/agent_omnibus.md Outdated Show resolved Hide resolved
docs/dev/agent_omnibus.md Outdated Show resolved Hide resolved
Co-Authored-By: Kaylyn <kaylyn.sigler@datadoghq.com>
@albertvaka albertvaka merged commit 5616f48 into master Jul 29, 2019
@albertvaka albertvaka deleted the albertvaka/docker-build-docs branch July 29, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. documentation team/baklava
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants