-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak docs to make Dockerized build more visible #3875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few nits 👍
If the build images crash when you run them on modern Linux distributions, you might be | ||
affected by [this bug](https://github.com/moby/moby/issues/28705). | ||
|
||
## Building on your system (Linux and Mac) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add here the requirements part of the Prepare the dev environment
section that was removed, since you do need these to run Omnibus locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need python and pip, clang, systemd headers, and a ton of other dependencies... I found the list so incomplete I thought it was better to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small grammar suggestions from the docs team
Co-Authored-By: Kaylyn <kaylyn.sigler@datadoghq.com>
Motivation
We made our builder images open source again, so we want to recommend using them.