[tasks] Make GOPATH optional #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly by fixing the logic in `bootstrap.process_deps`, and extracting out the logic into a function that should be called instead of querying GOPATH from the env directly.
olivielpeau
added
dev/tooling
[deprecated] team/agent-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make
GOPATHoptional in our invoke tasks.Motivation
Fixes #3617. Golang does not require the
GOPATHenv var to be set anymore (defaults to$HOME/go).Additional Notes
This PR mostly fixes the logic in
bootstrap.process_deps, and extractsout the logic into a function that should be called instead of querying
GOPATHfrom the env directly.