Fix tagger regression behavior with SIX #3767
Merged
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
requested changes
Jun 28, 2019
clamoriniere
force-pushed
the
clamoriniere/fixSixTagger
branch
2 times, most recently
from
c3a1b17 to
e3e97c9
Compare
albertvaka
previously approved these changes
Jun 28, 2019
hush-hush
approved these changes
Jun 28, 2019
hush-hush
requested changes
Jun 28, 2019
|
@hush-hush release note added |
hush-hush
requested changes
Jun 28, 2019
releasenotes/notes/Fix-tagger-regression-behavior-with-SIX-d1994c01432ff815.yaml
Outdated
Show resolved
Hide resolved
clamoriniere
force-pushed
the
clamoriniere/fixSixTagger
branch
from
a7fe2f2 to
9bd399e
Compare
hush-hush
previously approved these changes
Jun 28, 2019
|
You got conflicts because we renamed six to rtloader (sorry, I really thought this had been merged earlier!). Can you rebase and ping me so I give you a ✅ again? |
clamoriniere
force-pushed
the
clamoriniere/fixSixTagger
branch
2 times, most recently
from
8b61380 to
1384c6d
Compare
Previously in a python check, a call to the tagger.tag function, always return a list (empty or not). With the introduction of rtloader , in case of the absence of associated tag stored in the tagger, the function returns "NONE" that can break some checks (Kubelet check of instance).
clamoriniere
force-pushed
the
clamoriniere/fixSixTagger
branch
from
1384c6d to
39c4c6a
Compare
|
@albertvaka rebased done :) |
albertvaka
approved these changes
Jul 1, 2019
|
🙇 (and btw, this also makes me realize that the extension should raise a python error instead of returning |
|
@clamoriniere Should we merge this? |
|
@albertvaka Yes we can now merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously in a python check, a call to the tagger.tag function, always
return a list (empty or not). With the introduction of SIX, in case of
the absence of associated tag stored in the tagger, the function returns
"NONE" that can break some checks (Kubelet check of instance).
This fix restores the previous behavior.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?