Add configuration to make Go loader have priority over Python #37104

pgimalac · 2025-05-16T16:16:13Z

What does this PR do?

Add configuration to make Go loader have priority over Python.
It's disabled by default so that nothing changes for users.

Motivation

Eventually make Go have priority over Python.
For now just enables testing.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2025-05-16T16:44:25Z

Uncompressed package size comparison

Comparison with ancestor 1d5fb0182f46c8b375bebc89c10030c4ad3b0c94

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	0.00MB	✅	773.99MB	773.99MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	775.77MB	775.77MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	765.06MB	765.06MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	784.72MB	784.72MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	784.72MB	784.72MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.79MB	61.79MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.79MB	61.79MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.02MB	59.02MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	31.30MB	31.30MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	31.30MB	31.30MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.22MB	31.22MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.05MB	30.05MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	379.37MB	379.37MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.71MB	61.71MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	58.94MB	58.94MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-05-16T17:03:34Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 83450aba-a688-4a0c-a5ce-6b5c13d5b91e

Baseline: 4bfc72b
Comparison: 36402ed
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+1.19	[+1.12, +1.26]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.63	[+0.58, +0.68]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.57	[-2.51, +3.66]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.55	[+0.39, +0.71]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.45	[+0.38, +0.52]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.18	[+0.05, +0.31]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.05	[-0.19, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.55, +0.61]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.58, +0.61]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.56, +0.59]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.01, +0.03]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.27, +0.29]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.64, +0.62]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.01	[-0.66, +0.63]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.02	[-0.65, +0.61]	1	Logs
➖	ddot_metrics	memory utilization	-0.03	[-0.15, +0.08]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.04	[-0.67, +0.58]	1	Logs
➖	ddot_logs	memory utilization	-0.18	[-0.32, -0.04]	1	Logs
➖	quality_gate_idle	memory utilization	-0.21	[-0.27, -0.15]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.22	[-0.29, -0.15]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.37	[-0.49, -0.25]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.42	[-3.21, +2.37]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.31	[-2.15, -0.46]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	docker_containers_memory	memory_usage	0/10
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-05-16T18:04:22Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4bfc72b

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	DataNotFound	$${\color{green}747.05}$$ < $${752.99}$$	DataNotFound	$${\color{green}184.98}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	DataNotFound	$${\color{green}745.43}$$ < $${751.36}$$	DataNotFound	$${\color{green}184.41}$$ < $${187.06}$$
✅	agent_heroku_amd64	DataNotFound	$${\color{green}368.7}$$ < $${369.68}$$	DataNotFound	$${\color{green}98.68}$$ < $${99.55}$$
✅	agent_msi	DataNotFound	$${\color{green}986.26}$$ < $${987.01}$$	DataNotFound	$${\color{green}149.7}$$ < $${150.72}$$
✅	agent_rpm_amd64	DataNotFound	$${\color{green}747.04}$$ < $${752.98}$$	DataNotFound	$${\color{green}186.5}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	DataNotFound	$${\color{green}745.42}$$ < $${751.35}$$	DataNotFound	$${\color{green}186.23}$$ < $${189.81}$$
✅	agent_rpm_arm64	DataNotFound	$${\color{green}733.77}$$ < $${739.42}$$	DataNotFound	$${\color{green}168.64}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	DataNotFound	$${\color{green}732.27}$$ < $${737.91}$$	DataNotFound	$${\color{green}167.68}$$ < $${170.22}$$
✅	agent_suse_amd64	DataNotFound	$${\color{green}747.04}$$ < $${752.98}$$	DataNotFound	$${\color{green}186.5}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	DataNotFound	$${\color{green}745.42}$$ < $${751.35}$$	DataNotFound	$${\color{green}186.23}$$ < $${189.81}$$
✅	agent_suse_arm64	DataNotFound	$${\color{green}733.77}$$ < $${739.42}$$	DataNotFound	$${\color{green}168.64}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	DataNotFound	$${\color{green}732.27}$$ < $${737.91}$$	DataNotFound	$${\color{green}167.68}$$ < $${170.22}$$
✅	docker_agent_amd64	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_arm64	DataNotFound	$${\color{green}841.02}$$ < $${858.97}$$	DataNotFound	$${\color{green}268.28}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	DataNotFound	$${\color{green}841.02}$$ < $${858.97}$$	DataNotFound	$${\color{green}268.28}$$ < $${274.36}$$
✅	docker_agent_windows1809	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows2022	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	DataNotFound	$${\color{green}830.84}$$ < $${849.39}$$	DataNotFound	$${\color{green}282.17}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	DataNotFound	$${\color{green}259.08}$$ < $${259.73}$$	DataNotFound	$${\color{green}102.83}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	DataNotFound	$${\color{green}273.55}$$ < $${274.24}$$	DataNotFound	$${\color{green}97.56}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	DataNotFound	$${\color{green}7.08}$$ < $${7.12}$$	DataNotFound	$${\color{green}2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	DataNotFound	$${\color{green}6.69}$$ < $${6.92}$$	DataNotFound	$${\color{green}2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	DataNotFound	$${\color{green}38.9}$$ < $${39.57}$$	DataNotFound	$${\color{green}14.94}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	DataNotFound	$${\color{green}37.52}$$ < $${38.2}$$	DataNotFound	$${\color{green}13.95}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	DataNotFound	$${\color{green}30.58}$$ < $${31.52}$$	DataNotFound	$${\color{green}8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	DataNotFound	$${\color{green}29.14}$$ < $${30.08}$$	DataNotFound	$${\color{green}6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	DataNotFound	$${\color{green}30.58}$$ < $${31.52}$$	DataNotFound	$${\color{green}8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	DataNotFound	$${\color{green}30.58}$$ < $${31.52}$$	DataNotFound	$${\color{green}8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	DataNotFound	$${\color{green}59.89}$$ < $${60.17}$$	DataNotFound	$${\color{green}14.98}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	DataNotFound	$${\color{green}56.62}$$ < $${56.94}$$	DataNotFound	$${\color{green}12.85}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	DataNotFound	$${\color{green}56.07}$$ < $${56.41}$$	DataNotFound	$${\color{green}12.98}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	DataNotFound	$${\color{green}59.89}$$ < $${60.18}$$	DataNotFound	$${\color{green}14.99}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	DataNotFound	$${\color{green}56.62}$$ < $${56.94}$$	DataNotFound	$${\color{green}12.87}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	DataNotFound	$${\color{green}59.89}$$ < $${60.18}$$	DataNotFound	$${\color{green}14.99}$$ < $${15.84}$$

pgimalac · 2025-05-27T15:29:57Z

/merge

dd-devflow · 2025-05-27T15:30:02Z

View all feedbacks in Devflow UI.

2025-05-27 15:30:02 UTC ℹ️ Start processing command /merge

2025-05-27 15:30:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-05-27 15:36:04 UTC 🚨 MergeQueue: This merge request is in error

There was an unexpected error while creating the working branch

This could indicate that something doesn't work properly with the build system or that this one has reached its maximum capacity.
You can try to wait a bit and then re-add your pull request to the queue!

Details

child workflow execution error (type: mergequeue_private.MergeQueue_BuildWorkingBranch, workflowID: d5aca939-4a20-4e27-8587-c0332295a603_51, runID: 5a347709-12e7-4ed6-bf80-0fa9d9c6ba7e, initiatedEventID: 51, startedEventID: 52): Child workflow timeout (type: StartToClose)

pgimalac · 2025-06-02T08:51:30Z

/merge

dd-devflow · 2025-06-02T08:51:34Z

View all feedbacks in Devflow UI.

2025-06-02 08:51:34 UTC ℹ️ Start processing command /merge

2025-06-02 08:52:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-02 10:54:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-02 11:30:54 UTC ℹ️ MergeQueue: This merge request was merged

feat: add configuration to make Go loader have priority over Python

88ea0cd

pgimalac added the changelog/no-changelog label May 16, 2025

pgimalac requested a review from a team as a code owner May 16, 2025 16:16

pgimalac added the qa/done QA done before merge and regressions are covered by tests label May 16, 2025

pgimalac requested a review from a team as a code owner May 16, 2025 16:16

pgimalac added the team/agent-runtimes label May 16, 2025

pgimalac requested review from dustmop and jose-manuel-almaza May 16, 2025 16:16

github-actions bot added the short review PR is simple enough to be reviewed quickly label May 16, 2025

dustmop approved these changes May 16, 2025

View reviewed changes

jose-manuel-almaza approved these changes May 19, 2025

View reviewed changes

Merge branch 'main' into pgimalac/go-loader-priority-config

36402ed

dd-devflow bot mentioned this pull request Jun 2, 2025

Allow disabling kubelet, disk, and network core checks from config #36526

Merged

dd-mergequeue bot merged commit 0b2a5b1 into main Jun 2, 2025
236 checks passed

dd-mergequeue bot deleted the pgimalac/go-loader-priority-config branch June 2, 2025 11:30

github-actions bot added this to the 7.68.0 milestone Jun 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add configuration to make Go loader have priority over Python #37104

Add configuration to make Go loader have priority over Python #37104

Uh oh!

pgimalac commented May 16, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented May 16, 2025

Uh oh!

cit-pr-commenter bot commented May 16, 2025 •

edited

Loading

Fine details of change detection per experiment

Explanation

Uh oh!

agent-platform-auto-pr bot commented May 16, 2025 •

edited

Loading

Info

Uh oh!

pgimalac commented May 27, 2025

Uh oh!

dd-devflow bot commented May 27, 2025 •

edited

Loading

Uh oh!

pgimalac commented Jun 2, 2025

Uh oh!

dd-devflow bot commented Jun 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Add configuration to make Go loader have priority over Python #37104

Add configuration to make Go loader have priority over Python #37104

Uh oh!

Conversation

pgimalac commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented May 16, 2025

Uncompressed package size comparison

Decision

Uh oh!

cit-pr-commenter bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

pgimalac commented May 27, 2025

Uh oh!

dd-devflow bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgimalac commented Jun 2, 2025

Uh oh!

dd-devflow bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pgimalac commented May 16, 2025 •

edited

Loading

cit-pr-commenter bot commented May 16, 2025 •

edited

Loading

agent-platform-auto-pr bot commented May 16, 2025 •

edited

Loading

dd-devflow bot commented May 27, 2025 •

edited

Loading

dd-devflow bot commented Jun 2, 2025 •

edited

Loading