Skip to content

wip #37088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip #37088

wants to merge 1 commit into from

Conversation

ddrthall
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/container-platform The Container Platform Team medium review PR review might take time labels May 16, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 701bbb92679a61d93a5eb75d0a0d9a20d8809bb6

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 775.76MB 775.76MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 784.71MB 784.71MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 784.71MB 784.71MB 0.50MB
datadog-agent-arm64-deb 0.00MB 765.05MB 765.05MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 773.98MB 773.98MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 31.22MB 31.22MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 30.05MB 30.05MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 379.36MB 379.36MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.70MB 61.70MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.78MB 61.78MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.78MB 61.78MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 58.93MB 58.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.02MB 59.02MB 0.50MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ea83ba03-b144-4483-baec-c00dfd154e34

Baseline: 701bbb9
Comparison: 50b441e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +1.25 [+1.21, +1.30] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.87 [+0.83, +0.91] 1 Logs
docker_containers_memory memory utilization +0.86 [+0.81, +0.91] 1 Logs
ddot_logs memory utilization +0.31 [+0.18, +0.43] 1 Logs
ddot_metrics memory utilization +0.17 [+0.05, +0.29] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.08 [-0.54, +0.71] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.60, +0.71] 1 Logs
quality_gate_idle_all_features memory utilization +0.04 [-0.04, +0.13] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.02 [-0.03, +0.08] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.61, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.29, +0.28] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.24, +0.22] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.67, +0.63] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.67, +0.61] 1 Logs
quality_gate_logs % cpu utilization -0.06 [-2.83, +2.72] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.71, +0.59] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.69, +0.54] 1 Logs
otlp_ingest_metrics memory utilization -0.16 [-0.33, -0.00] 1 Logs
file_tree memory utilization -0.38 [-0.53, -0.23] 1 Logs
otlp_ingest_logs memory utilization -0.72 [-0.85, -0.60] 1 Logs
docker_containers_cpu % cpu utilization -0.87 [-4.69, +2.95] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.51 [-2.42, -0.60] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 748.38 MiB 778.06 MiB 185.89 MiB 191.06 MiB
static_quality_gate_agent_deb_amd64_fips 746.21 MiB 776.09 MiB 185.11 MiB 190.72 MiB
static_quality_gate_agent_heroku_amd64 367.77 MiB 434.99 MiB 98.44 MiB 114.34 MiB
static_quality_gate_agent_msi 966.22 MiB 978.45 MiB 147.2 MiB 151.65 MiB
static_quality_gate_agent_rpm_amd64 748.36 MiB 778.06 MiB 187.39 MiB 193.42 MiB
static_quality_gate_agent_rpm_amd64_fips 746.2 MiB 776.06 MiB 186.97 MiB 192.61 MiB
static_quality_gate_agent_rpm_arm64 738.13 MiB 768.33 MiB 169.92 MiB 174.71 MiB
static_quality_gate_agent_rpm_arm64_fips 736.18 MiB 766.55 MiB 168.84 MiB 173.92 MiB
static_quality_gate_agent_suse_amd64 748.36 MiB 778.08 MiB 187.39 MiB 193.42 MiB
static_quality_gate_agent_suse_amd64_fips 746.2 MiB 776.11 MiB 186.97 MiB 192.78 MiB
static_quality_gate_agent_suse_arm64 738.13 MiB 768.31 MiB 169.92 MiB 174.71 MiB
static_quality_gate_agent_suse_arm64_fips 736.18 MiB 766.5 MiB 168.84 MiB 173.92 MiB
static_quality_gate_docker_agent_amd64 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_arm64 857.68 MiB 876.0 MiB 272.82 MiB 278.3 MiB
static_quality_gate_docker_agent_jmx_amd64 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_jmx_arm64 857.68 MiB 876.63 MiB 272.82 MiB 278.4 MiB
static_quality_gate_docker_agent_windows1809 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_core 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_core_jmx 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_jmx 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_core 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_core_jmx 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_jmx 844.77 MiB 862.5 MiB 286.41 MiB 292.0 MiB
static_quality_gate_docker_cluster_agent_amd64 256.97 MiB 263.4 MiB 101.97 MiB 104.07 MiB
static_quality_gate_docker_cluster_agent_arm64 273.0 MiB 279.38 MiB 96.97 MiB 98.95 MiB
static_quality_gate_docker_cws_instrumentation_amd64 6.66 MiB 7.12 MiB 2.82 MiB 3.29 MiB
static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
static_quality_gate_docker_dogstatsd_amd64 37.9 MiB 46.39 MiB 14.61 MiB 17.78 MiB
static_quality_gate_docker_dogstatsd_arm64 36.85 MiB 45.05 MiB 13.74 MiB 16.65 MiB
static_quality_gate_dogstatsd_deb_amd64 29.85 MiB 38.4 MiB 7.9 MiB 10.26 MiB
static_quality_gate_dogstatsd_deb_arm64 28.73 MiB 36.98 MiB 6.88 MiB 8.96 MiB
static_quality_gate_dogstatsd_rpm_amd64 29.85 MiB 38.4 MiB 7.91 MiB 10.27 MiB
static_quality_gate_dogstatsd_suse_amd64 29.85 MiB 38.4 MiB 7.91 MiB 10.27 MiB
static_quality_gate_iot_agent_deb_amd64 58.92 MiB 59.14 MiB 14.82 MiB 15.02 MiB
static_quality_gate_iot_agent_deb_arm64 56.28 MiB 56.57 MiB 12.78 MiB 13.05 MiB
static_quality_gate_iot_agent_deb_armhf 55.03 MiB 55.28 MiB 12.8 MiB 13.05 MiB
static_quality_gate_iot_agent_rpm_amd64 58.92 MiB 59.14 MiB 14.84 MiB 15.04 MiB
static_quality_gate_iot_agent_rpm_arm64 56.28 MiB 56.57 MiB 12.79 MiB 13.07 MiB
static_quality_gate_iot_agent_suse_amd64 58.92 MiB 59.14 MiB 14.84 MiB 15.04 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant