Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/network-tracer/system-probe #3508

Merged
merged 5 commits into from
May 22, 2019
Merged

s/network-tracer/system-probe #3508

merged 5 commits into from
May 22, 2019

Conversation

sfluor
Copy link
Contributor

@sfluor sfluor commented May 20, 2019

What does this PR do?

Renames the network-tracer into system-probe

Motivation

Better name for the network-tracer

Additional Notes

@sfluor sfluor requested a review from a team as a code owner May 20, 2019 21:02
@sfluor sfluor requested a review from a team May 20, 2019 21:02
@sfluor sfluor requested a review from a team as a code owner May 20, 2019 21:02
@sfluor sfluor added this to the 6.12.0 milestone May 20, 2019
@sfluor sfluor force-pushed the sami/the-great-renaming branch from f56bd32 to b3a3668 Compare May 20, 2019 21:16
sunhay
sunhay reviewed May 20, 2019
View reviewed changes
cmd/system-probe/main.go Outdated Show resolved Hide resolved
sunhay
sunhay previously approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@sunhay sunhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me - we'll need to change our internal daemon set + chef recipes to handle this as well

olivielpeau
olivielpeau previously approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes on the invoke tasks and the packaging, LGTM if you've confirmed the gitlab pipeline on your branch passes 😄

sunhay
sunhay previously approved these changes May 21, 2019
View reviewed changes
@KSerrania KSerrania mentioned this pull request May 22, 2019
Merged
hkaj
hkaj previously approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@hkaj hkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you may want to update CODEOWNER and the .gitignore as well.

@sfluor sfluor dismissed stale reviews from hkaj, sunhay, and olivielpeau via 1d1c870 May 22, 2019 14:01
@sfluor sfluor merged commit 1acb7bb into master May 22, 2019
@sfluor sfluor deleted the sami/the-great-renaming branch May 22, 2019 15:14
@olivielpeau olivielpeau mentioned this pull request Jun 6, 2019
Merged
@julien-lebot julien-lebot mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaj hkaj hkaj approved these changes

@olivielpeau olivielpeau olivielpeau approved these changes

@sunhay sunhay sunhay approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog team/burrito
Projects
None yet
Milestone
6.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sfluor @sunhay @olivielpeau @hkaj