[backport 7.61.x] [bug fix] address configsync issues to prevent cpu leak in otel-agent #32645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
added
changelog/no-changelog
qa/rc-required
truthbk
requested review from
songy23 and
jeremy-hanna
and removed request for
a team
github-actions
bot
added
long review
hush-hush
approved these changes
Jan 3, 2025
songy23
approved these changes
Jan 3, 2025
paulcacheux
approved these changes
Jan 3, 2025
| cfg, err := fetchConfig(cs.ctx, cs.client, cs.Authtoken.Get(), cs.url.String()) | ||
| if err != nil { | ||
| if cs.connected { | ||
| cs.Log.Warnf("Failed to fetch config from core agent: %v", err) | ||
| cs.Log.Warnf("Loosed connectivity to core-agent to fetch config: %v", err) |
There was a problem hiding this comment.
Better grammar..
Suggested change
| cs.Log.Warnf("Loosed connectivity to core-agent to fetch config: %v", err) | |
| cs.Log.Warnf("Lost connectivity to core-agent to fetch config: %v", err) |
There was a problem hiding this comment.
Interesting, I made exactly the same comment in the original PR and thought that had been fixed.
Let's fix it in the main branch, and let that get picked up later. I'd rather not change the backported PRs at all.
ajgajg1134
approved these changes
Jan 3, 2025
StephenWakely
approved these changes
Jan 3, 2025
daniel-taf
approved these changes
Jan 3, 2025
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=52099698 --os-family=ubuntuNote: This applies to commit 414ac31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR backports:
Motivation
Previous RC's showed an issue by which badly resolved secrets caused a CPU leak in the
otel-agent. By properly resolving secrets with a new resolution pattern, we can now prevent such behavior.Describe how you validated your changes
This was validated in gizmo.
Should also be validated with the correct and healthy behavior of an RC with the
otel-agentenabled through-out staging with no noticeable increase in cpu or memory over time for the deployed agents.Possible Drawbacks / Trade-offs
Additional Notes
This does not solve the root cause, which is in the datadog exporter and is caused by an accumulation of failed transactions. While a CPU increase can be caused by failed transaction and their reattempt, we need to make sure any resource impact is bounded.