Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add apm_config.obfuscation.cache.max_size to set the maximum size of obfuscation query cache" #32629

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

FlorentClarret
Copy link
Member

Reverts #32294 because of #incident-33608 to re-enable nightly builds

@FlorentClarret FlorentClarret requested review from a team as code owners January 3, 2025 08:42
@github-actions github-actions bot added medium review PR review might take time team/agent-apm trace-agent labels Jan 3, 2025
@FlorentClarret FlorentClarret added the qa/no-code-change No code change in Agent code requiring validation label Jan 3, 2025
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 3, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-03 12:00:16 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-03 12:02:06 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@FlorentClarret FlorentClarret merged commit 6bb724c into main Jan 3, 2025
23 of 34 checks passed
@FlorentClarret FlorentClarret deleted the revert-32294-keisku/obfuscation-cache-size branch January 3, 2025 12:02
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 3, 2025
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a90432d0-592d-43e1-936a-a089f7d30e05

Baseline: 5959c15
Comparison: 9332fc6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.99 [+1.31, +2.68] 1 Logs
quality_gate_logs % cpu utilization +1.51 [-1.77, +4.79] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.77 [-0.02, +1.55] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.38 [-0.08, +0.84] 1 Logs
quality_gate_idle memory utilization +0.20 [+0.17, +0.24] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.20 [+0.14, +0.27] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.72, +0.83] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.86, +0.97] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.00 [-0.87, +0.87] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.88, +0.83] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.74, +0.67] 1 Logs
quality_gate_idle_all_features memory utilization -0.10 [-0.18, -0.01] 1 Logs bounds checks dashboard
file_tree memory utilization -0.29 [-0.42, -0.17] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants