Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test-infra): Bump to latest version #30900

Open
wants to merge 6 commits into
base: 6.53.x
Choose a base branch
from
Open

feat(test-infra): Bump to latest version #30900

wants to merge 6 commits into from
+5,686 −1,553

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Nov 8, 2024 •
edited
Loading

What does this PR do?

Bump test-infra definition to the latest version to be able to run new-e2e tests running on Agent6

Motivation

https://datadoghq.atlassian.net/browse/ACIX-496

Describe how to test/QA your changes

tests/linters are passing on the branch

Possible Drawbacks / Trade-offs

Additional Notes

Note

You can review the PR by commit

Pipeline status:

Besides, I've launched a full pipeline on this PR to assess the status:

  • qa_agent: issue with windows image name (severcore, because nanoserver does not support python2)
  • install_scripts: they still run with agent7

@chouetz
Copy link
Member Author

chouetz commented Nov 8, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Nov 8, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.

2024-11-08 14:00:56 UTC ℹ️ Gitlab pipeline started

Started pipeline #48559069

@chouetz
Copy link
Member Author

chouetz commented Nov 12, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Nov 12, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.

2024-11-12 15:19:55 UTC ℹ️ Gitlab pipeline started

Started pipeline #48806937

@chouetz
Copy link
Member Author

chouetz commented Nov 12, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Nov 12, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.

2024-11-12 17:13:08 UTC ℹ️ Gitlab pipeline started

Started pipeline #48823499

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024 •
edited
Loading

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48898817 --os-family=ubuntu

@chouetz chouetz marked this pull request as ready for review November 13, 2024 13:04
@chouetz chouetz requested review from a team as code owners November 13, 2024 13:04
@chouetz chouetz requested review from Jakobovski and louis-cqrl and removed request for a team November 13, 2024 13:04
@chouetz chouetz added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels Nov 13, 2024
chouetz
chouetz commented Nov 13, 2024
View reviewed changes
junit-local.tgz Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, removed on the last commit

CelianR
CelianR approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@CelianR CelianR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commit-by-commit review! LGTM

AliDatadog
AliDatadog reviewed Nov 13, 2024
View reviewed changes
.gitlab/internal_image_deploy/internal_image_deploy.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this job. This is for internal deployments only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliDatadog AliDatadog AliDatadog left review comments

@CelianR CelianR CelianR approved these changes

@Jakobovski Jakobovski Jakobovski approved these changes

@louis-cqrl louis-cqrl Awaiting requested review from louis-cqrl louis-cqrl is a code owner automatically assigned from DataDog/agent-shared-components

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chouetz @Jakobovski @AliDatadog @CelianR