-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network path] Add missing origin field in network path integration #29563
Conversation
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45112157 --os-family=ubuntu Note: This applies to commit 16a7e8b |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Regression DetectorRegression Detector ResultsRun ID: a4fff177-4c73-49f3-91d5-206d7ce4ac7a Metrics dashboard Target profiles Baseline: 456feb4 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.66 | [+0.92, +2.40] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.60 | [+0.54, +0.65] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.09, +0.09] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.19 | [-1.00, +0.61] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -0.31 | [-3.08, +2.45] | 1 | Logs |
➖ | idle | memory utilization | -0.34 | [-0.38, -0.30] | 1 | Logs |
➖ | file_tree | memory utilization | -0.35 | [-0.44, -0.26] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -3.01 | [-5.57, -0.46] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
/merge -c |
This merge request build was cancelled If you need support, contact us on Slack #devflow! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
[network path] Add missing origin field in network path integration
Bug fix related to this PR with 7.58 milestone: #28742
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes