Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade/downgrade Windows Agent via uninstall -> install #29555

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented Sep 24, 2024

What does this PR do?

When starting/stopping Fleet Automation experiments for the Agent package on Windows, change version by uninstalling the current version, then installing the next version.

Motivation

support downgrade scenarios

  • start experiment to downgrade Agent version
  • stop experiment must "rollback" to lower Agent version

https://datadoghq.atlassian.net/browse/WINA-998

Describe how to test/QA your changes

N/A, has E2E tests for upgrade+stop experiment and downgrade/start-experiment

Possible Drawbacks / Trade-offs

Additional Notes

no changelog, unreleased feature

@clarkb7 clarkb7 added changelog/no-changelog team/windows-agent qa/no-code-change Skip QA week as there is no code change in Agent code labels Sep 24, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45051351 --os-family=ubuntu

Note: This applies to commit 5cd3e79

@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Regression Detector

Regression Detector Results

Run ID: fe4ae922-b812-4ffe-a33c-feb1dc4cd8f2 Metrics dashboard Target profiles

Baseline: 42db7b3
Comparison: 5cd3e79

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +2.32 [+2.22, +2.41] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.99 [-1.51, +3.48] 1 Logs
idle memory utilization +0.50 [+0.44, +0.56] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.48 [-0.26, +1.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.21 [-0.27, -0.16] 1 Logs
basic_py_check % cpu utilization -0.28 [-2.96, +2.41] 1 Logs
otel_to_otel_logs ingress throughput -0.36 [-1.16, +0.44] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@clarkb7 clarkb7 marked this pull request as ready for review September 25, 2024 00:14
@clarkb7 clarkb7 requested review from a team as code owners September 25, 2024 00:14
@clarkb7 clarkb7 added qa/done Skip QA week as QA was done before merge and regressions are covered by tests and removed qa/no-code-change Skip QA week as there is no code change in Agent code labels Sep 25, 2024
@clarkb7
Copy link
Contributor Author

clarkb7 commented Sep 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 3c4c7ec into main Sep 26, 2024
280 checks passed
@dd-mergequeue dd-mergequeue bot deleted the branden.clark/fleet-agent-uninstall-install branch September 26, 2024 14:19
@github-actions github-actions bot added this to the 7.59.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants