retry omnibus code signing #29552
retry omnibus code signing #29552
Conversation
clarkb7
added
changelog/no-changelog
team/windows-agent
qa/no-code-change
|
[Fast Unit Tests Report] On pipeline 45045351 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsRun ID: 05f7e92b-160a-42b9-ba8e-3f50d6951f23 Metrics dashboard Target profiles Baseline: ec036f7 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +1.17 | [+0.36, +1.98] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.11, +0.06] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.05 | [-0.11, +0.00] | 1 | Logs |
| ➖ | idle | memory utilization | -0.81 | [-0.87, -0.75] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.01 | [-1.73, -0.28] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -1.21 | [-3.89, +1.46] | 1 | Logs |
| ➖ | file_tree | memory utilization | -1.32 | [-1.44, -1.21] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -2.26 | [-4.81, +0.29] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
LGTM but isn't it a bit too optimistic to have all the attempts grouped in about 6 seconds if the timeserver is flaky?
Increasing the delay and having more retries would seem more robust, although you definitely know more about the timeserver's behavior, so I'll let you decide if it's really needed or not :)
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add retry loop to code signing in omnibus build
If all retries fail, raise the error to fail the build and job.
Motivation
signing can flake, for example if the timestamp server isn't responding
failure can be detected since https://github.com/DataDog/windows-code-signer/pull/21, so we can fail the build instead of failing later in the tests
Describe how to test/QA your changes
N/A. build job should succeed and E2E tests should validate signing.
Possible Drawbacks / Trade-offs
would be neat for
dd-wcsto have a--retryoption so we don't have to implement a retry loop everywhere we use it.Additional Notes