-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compare_to): Use 2 different commit messages #29541
Conversation
a5866ed
to
dee12d1
Compare
[Fast Unit Tests Report] On pipeline 45080809 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsRun ID: 8b8d5982-1724-47f0-87b7-991f7e464d69 Metrics dashboard Target profiles Baseline: c758448 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +1.49 | [-1.29, +4.27] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.11 | [+0.36, +1.86] | 1 | Logs |
➖ | idle | memory utilization | +0.05 | [+0.00, +0.09] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.08, +0.09] | 1 | Logs |
➖ | file_tree | memory utilization | +0.01 | [-0.08, +0.09] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.42 | [-0.47, -0.37] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.72 | [-1.52, +0.08] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.75 | [-4.26, +0.75] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
dee12d1
to
6d659c7
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Use different commit message when pushing the initial branch for
compare_to
test and the commit that modifies thecompare_to: main
contentMotivation
As sometimes gitlab displays both pipelines (the initial push and the modified commit) having both with the same commit name was confusing
Describe how to test/QA your changes
Pushed a "fake commit" to generate the
compare_to
testBefore:
After:
Possible Drawbacks / Trade-offs
Additional Notes