Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-delve/delve from 1.20.1 to 1.23.1 #29522

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024

Bumps github.com/go-delve/delve from 1.20.1 to 1.23.1.

Release notes

Sourced from github.com/go-delve/delve's releases.

v1.23.1

What's Changed

New Contributors

Curated Changelog: https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1231-2024-09-23

v1.23.0

What's Changed

... (truncated)

Changelog

Sourced from github.com/go-delve/delve's changelog.

[1.23.1] 2024-09-23

Telemetry notice: starting with version 1.24.0 Delve will begin collecting opt-in telemetry data using the same mechanism used by the toolchain, see golang/go#68384, https://go.dev/doc/telemetry#background, go-delve/delve#3815.

Fixed

[1.23.0] 2024-07-16

Deprecation notice: starting with the next version of Delve version 1 of the API will be removed. Version 2 was added in version 0.12.0 in 2017 and has been the recommended way to connect to Delve since.

Added

Fixed

Changed

[1.22.1] 2024-02-21

Added

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Sep 23, 2024
Copy link

cit-pr-commenter bot commented Sep 23, 2024

Go Package Import Differences

Baseline: 418e339
Comparison: fb1c009

binaryosarchchange
system-probelinuxamd64
+2, -1
+github.com/go-delve/delve/pkg/dwarf
+github.com/go-delve/delve/pkg/dwarf/leb128
-github.com/go-delve/delve/pkg/dwarf/util
system-probelinuxarm64
+2, -1
+github.com/go-delve/delve/pkg/dwarf
+github.com/go-delve/delve/pkg/dwarf/leb128
-github.com/go-delve/delve/pkg/dwarf/util

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-delve/delve-1.23.1 branch 2 times, most recently from 1ec4352 to b231c11 Compare October 4, 2024 10:27
@pgimalac
Copy link
Member

pgimalac commented Oct 7, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-delve/delve-1.23.1 branch from b231c11 to 6deca49 Compare October 7, 2024 08:43
@pgimalac pgimalac added the qa/no-code-change Skip QA week as there is no code change in Agent code label Oct 7, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-delve/delve-1.23.1 branch 4 times, most recently from fa32009 to 5530bbd Compare October 8, 2024 10:49
Bumps [github.com/go-delve/delve](https://github.com/go-delve/delve) from 1.20.1 to 1.23.1.
- [Release notes](https://github.com/go-delve/delve/releases)
- [Changelog](https://github.com/go-delve/delve/blob/master/CHANGELOG.md)
- [Commits](go-delve/delve@v1.20.1...v1.23.1)

---
updated-dependencies:
- dependency-name: github.com/go-delve/delve
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@paulcacheux paulcacheux force-pushed the dependabot/go_modules/github.com/go-delve/delve-1.23.1 branch from 5530bbd to 9949618 Compare October 25, 2024 08:08
@paulcacheux paulcacheux requested a review from a team as a code owner October 25, 2024 08:08
@paulcacheux paulcacheux added qa/done Skip QA week as QA was done before merge and regressions are covered by tests and removed qa/no-code-change Skip QA week as there is no code change in Agent code labels Oct 25, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47424990 --os-family=ubuntu

Note: This applies to commit fb1c009

@paulcacheux
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 25, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

Copy link

Regression Detector

Regression Detector Results

Run ID: 2e6d7b02-d721-4167-9088-768db2369ada Metrics dashboard Target profiles

Baseline: 418e339
Comparison: fb1c009

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +2.31 [-0.25, +4.88] 1 Logs
idle_all_features memory utilization +1.10 [+0.98, +1.23] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +1.10 [+0.38, +1.82] 1 Logs
file_tree memory utilization +0.65 [+0.53, +0.77] 1 Logs
otel_to_otel_logs ingress throughput +0.25 [-0.56, +1.06] 1 Logs
basic_py_check % cpu utilization +0.24 [-2.48, +2.95] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.40, +0.58] 1 Logs
quality_gate_idle memory utilization +0.04 [-0.00, +0.09] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.15, +0.22] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.09, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.22, +0.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.35, +0.31] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.34, +0.16] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.18 [-0.23, -0.13] 1 Logs
idle memory utilization -0.52 [-0.57, -0.47] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.93 [-1.04, -0.83] 1 Logs bounds checks dashboard

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 922d783 into main Oct 25, 2024
291 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot/go_modules/github.com/go-delve/delve-1.23.1 branch October 25, 2024 10:26
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants