-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add the integration tests to Gitlab CI #29489
base: main
Are you sure you want to change the base?
Conversation
Regression DetectorRegression Detector ResultsRun ID: 942d01a8-7ac4-4373-b0ad-df7bfded3092 Metrics dashboard Target profiles Baseline: 34754e5 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +1.67 | [-1.10, +4.44] | 1 | Logs |
➖ | idle | memory utilization | +0.22 | [+0.17, +0.27] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.18 | [-0.56, +0.93] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.02 | [-0.78, +0.83] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.09, +0.12] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_tree | memory utilization | -0.35 | [-0.46, -0.24] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.40 | [-0.45, -0.34] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.60 | [-4.08, +0.88] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Gitlab CI Configuration ChangesAdded Jobs.integration_tests_deb.integration_tests_deb:
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- go_tools_deps
stage: source_test
tags:
- docker-in-docker:amd64 agent_integration_testsagent_integration_tests:
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- go_tools_deps
script:
- mkdir -p $GOPATH/pkg/mod && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod
- rm -f modcache_tools.tar.xz
- inv -e integration-tests --race --remote-docker
stage: source_test
tags:
- docker-in-docker:amd64 docker_integration_testsdocker_integration_tests:
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_deps
- go_tools_deps
script:
- mkdir -p $GOPATH/pkg/mod && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod
- rm -f modcache_tools.tar.xz
- inv -e docker.test
- inv -e docker.integration-tests
stage: source_test
tags:
- docker-in-docker:amd64 Changes Summary
|
What does this PR do?
This PR adds the integration jobs from CircleCI to Gitlab CI.
Motivation
This is a prerequisite for #29463 which aims at decommissioning CircleCI.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes