Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2307] Fix health subcommand Windows e2e test and unify with Linux #29429

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

pgimalac
Copy link
Member

What does this PR do?

Fix the Windows version of the health subcommand e2e test, and unify the implementation with Linux.

Motivation

The test should not be skipped on Windows if possible.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/no-code-change Skip QA week as there is no code change in Agent code labels Sep 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 18, 2024

[Fast Unit Tests Report]

On pipeline 45028740 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45028740 --os-family=ubuntu

Note: This applies to commit ac21d30

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Regression Detector

Regression Detector Results

Run ID: 1aed787b-d70b-4e67-9b8b-4541f170efca Metrics dashboard Target profiles

Baseline: d5c11ef
Comparison: ac21d30

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.51 [+0.46, +0.56] 1 Logs
idle memory utilization +0.05 [+0.00, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.10, +0.08] 1 Logs
file_tree memory utilization -0.14 [-0.23, -0.05] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.27 [-2.76, +2.22] 1 Logs
otel_to_otel_logs ingress throughput -0.73 [-1.53, +0.07] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.50 [-2.23, -0.78] 1 Logs
basic_py_check % cpu utilization -1.92 [-4.53, +0.69] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pgimalac pgimalac marked this pull request as ready for review September 24, 2024 15:44
@pgimalac pgimalac requested a review from a team as a code owner September 24, 2024 15:44
@pgimalac pgimalac changed the title Fix health subcommand Windows e2e test and unify with Linux [ASCII-2307] Fix health subcommand Windows e2e test and unify with Linux Sep 24, 2024
@pgimalac
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit ee133be into main Sep 26, 2024
224 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/fix-health-e2e-windows branch September 26, 2024 12:55
@github-actions github-actions bot added this to the 7.59.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants