Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usm: Refactor nodejs monitor to use new uprobe attacher #29305

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Sep 12, 2024

What does this PR do?

This PR applies the new uprobe attacher introduced in #27663 to the NodeJS monitor.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Validated in system-probe load testing environment, using the soak_test and processes scenarios. Base version is agent release 7.57

soak_test

Summary: similar accuracy results, no significant difference in resource usage.

Dashboard

Resource usage:
Screenshot 2024-09-16 at 14 53 26

Accuracy for base:
Screenshot 2024-09-16 at 14 54 58

Accuracy for new (this branch):
Screenshot 2024-09-16 at 14 54 50

Accuracy comparison:

Screenshot 2024-09-16 at 14 54 35
processes

Summary: negligible resource usage differences.

Dashboard

Resource usage:

Screenshot 2024-09-16 at 16 08 59

Copy link

cit-pr-commenter bot commented Sep 12, 2024

Go Package Import Differences

Baseline: fdc7ee2
Comparison: c8abe71

binaryosarchchange
system-probelinuxamd64
+4, -0
+github.com/DataDog/datadog-agent/pkg/ebpf/uprobes
+github.com/DataDog/datadog-agent/pkg/network/protocols/http/testutil
+github.com/lorenzosaino/go-sysctl
+golang.org/x/net/netutil
system-probelinuxarm64
+4, -0
+github.com/DataDog/datadog-agent/pkg/ebpf/uprobes
+github.com/DataDog/datadog-agent/pkg/network/protocols/http/testutil
+github.com/lorenzosaino/go-sysctl
+golang.org/x/net/netutil

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45087902 --os-family=ubuntu

Note: This applies to commit c8abe71

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024

Regression Detector

Regression Detector Results

Run ID: 7b666a7a-3fcd-4ece-9105-f965b9112212 Metrics dashboard Target profiles

Baseline: fdc7ee2
Comparison: c8abe71

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +2.34 [-0.29, +4.97] 1 Logs
idle memory utilization +1.05 [+1.00, +1.09] 1 Logs
file_tree memory utilization +0.31 [+0.22, +0.40] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.04 [-0.08, +0.00] 1 Logs
otel_to_otel_logs ingress throughput -0.09 [-0.90, +0.71] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.16 [-0.90, +0.59] 1 Logs
basic_py_check % cpu utilization -1.86 [-4.62, +0.90] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@gjulianm gjulianm added this to the 7.59.0 milestone Sep 13, 2024
Base automatically changed from guillermo.julian/uprobe-attacher to main September 13, 2024 15:09
@gjulianm gjulianm force-pushed the guillermo.julian/uprobe-attacher-nodejs branch from 70a7d6c to 323e491 Compare September 13, 2024 15:57
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 13, 2024

[Fast Unit Tests Report]

On pipeline 45087902 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@gjulianm gjulianm force-pushed the guillermo.julian/uprobe-attacher-nodejs branch from 323e491 to 11d5b99 Compare September 16, 2024 20:13
@gjulianm gjulianm marked this pull request as ready for review September 16, 2024 20:13
@gjulianm gjulianm requested a review from a team as a code owner September 16, 2024 20:13
pkg/network/usm/nodejs.go Outdated Show resolved Hide resolved
pkg/network/usm/nodejs.go Outdated Show resolved Hide resolved
Comment on lines 130 to 132
if err != nil {
log.Errorf("Cannot create uprobe attacher: %v", err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we failed creating the attacher, why do we continue?

Copy link
Contributor Author

@gjulianm gjulianm Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An oversight. I changed the code to check and return the error if it happens

@gjulianm gjulianm requested a review from a team as a code owner September 24, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants