Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/term from 0.23.0 to 0.24.0 in /test/new-e2e #29192

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps golang.org/x/term from 0.23.0 to 0.24.0.

Commits
  • 2f7b0dd go.mod: update golang.org/x dependencies
  • f867b76 x/term: set missing VIRTUAL_TERMINAL_INPUT flag on Windows
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 9, 2024 20:44
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency labels Sep 9, 2024
@dependabot dependabot bot requested a review from a team as a code owner September 9, 2024 20:44
@dependabot dependabot bot added dependencies-go PRs that bump a go dependency dev/testing qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-e2e-test labels Sep 9, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/test/new-e2e/golang.org/x/term-0.24.0 branch from afe2f50 to 06a8dca Compare September 10, 2024 10:20
@pr-commenter
Copy link

pr-commenter bot commented Sep 10, 2024

Regression Detector

Regression Detector Results

Run ID: 0dab025c-574a-4965-8e7d-190d17de8b53 Metrics dashboard Target profiles

Baseline: 6e8be0f
Comparison: 39321bd

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +1.68 [+1.56, +1.81] 1 Logs
idle memory utilization +0.25 [+0.20, +0.30] 1 Logs
basic_py_check % cpu utilization +0.20 [-2.53, +2.92] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.08, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.05 [-0.11, +0.01] 1 Logs
otel_to_otel_logs ingress throughput -0.07 [-0.88, +0.74] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.18 [-2.69, +2.32] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.60 [-1.33, +0.13] 1 Logs
idle_all_features memory utilization -0.87 [-1.00, -0.74] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dependabot dependabot bot force-pushed the dependabot/go_modules/test/new-e2e/golang.org/x/term-0.24.0 branch from 06a8dca to a8ba7eb Compare September 25, 2024 17:00
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 25, 2024

[Fast Unit Tests Report]

On pipeline 45508687 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.23.0 to 0.24.0.
- [Commits](golang/term@v0.23.0...v0.24.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/test/new-e2e/golang.org/x/term-0.24.0 branch from a8ba7eb to 39321bd Compare October 1, 2024 12:48
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2024

Looks like golang.org/x/term is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Oct 4, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/test/new-e2e/golang.org/x/term-0.24.0 branch October 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency dev/testing qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-e2e-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants