-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fips mode to the Agent #28659
Add fips mode to the Agent #28659
Conversation
Regression DetectorRegression Detector ResultsRun ID: 8f8f2793-eb24-48cb-b96a-4e5386b84d52 Metrics dashboard Target profiles Baseline: 22686e5 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | file_tree | memory utilization | +4.08 | [+4.00, +4.17] | 1 | Logs |
➖ | idle | memory utilization | +2.96 | [+2.91, +3.01] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +1.10 | [+0.29, +1.91] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +0.45 | [-2.03, +2.93] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.09, +0.09] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.03 | [-0.77, +0.72] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.38 | [-0.44, -0.33] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -1.22 | [-3.99, +1.55] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
ce45213
to
d24e3d0
Compare
Gitlab CI Configuration Changes
|
Removed | Modified | Added | Renamed |
---|---|---|---|
0 | 57 | 3 | 0 |
e70d70c
to
8e73b3a
Compare
b60c8fe
to
dee3678
Compare
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
…penssl installation Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
…container cmd Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
dee3678
to
17c51fc
Compare
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
17c51fc
to
638e529
Compare
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
f967f16
to
150a9c6
Compare
…ent is removed during uninstall Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
cebe211
to
c23b375
Compare
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
c23b375
to
1d31f3d
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45072228 --os-family=ubuntu Note: This applies to commit 98faafe |
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
1923c1b
to
a1affe0
Compare
a1affe0
to
f060eec
Compare
03e887b
to
e5d3c60
Compare
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats
|
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
e5d3c60
to
98faafe
Compare
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
WIP, still a rough draft because I have some questions
Questions
agent version
subcommand ?TODOs