[ASCII-1936] Update Golang to 1.22.5 #27318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team/agent-devx-loops
ogaca-dd
reviewed
Jul 4, 2024
| @@ -130,11 +130,11 @@ def dependency_path(self, agent_version): | |||
| ".", | |||
| targets=["./pkg", "./cmd", "./comp"], | |||
| ), | |||
| "cmd/agent/common/path": GoModule("cmd/agent/common/path", independent=True), | |||
| "comp/api/api/def": GoModule("comp/api/api/def", independent=True), | |||
| "cmd/agent/common/path": GoModule("cmd/agent/common/path", independent=True, used_by_otel=True), | |||
There was a problem hiding this comment.
cmd/agent/common/path is used in comp/core/config module.
It is only used in comp/core/config/params_test.go to get DefaultConfPath.
Should we try to use another way to get DefaultConfPath to avoid having it as a dependency ?
misteriaud
changed the title
amenasria
approved these changes
Jul 4, 2024
Pythyu
approved these changes
Jul 4, 2024
kayayarai
approved these changes
Jul 4, 2024
pgimalac
approved these changes
Jul 5, 2024
pgimalac
added
[deprecated] team/agent-shared-components
KevinFairise2
approved these changes
Jul 5, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildimages update
This PR updates the current buildimages (
v37150619-8250a4fc) tov38375519-53773733, here is the full changelog.Golang update
This PR updates the current Golang version (
1.22.4) to1.22.5.Describe how to test/QA your changes
Covered by the QA of #26488.