Skip to content

Conversation

KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented Jul 3, 2024

What does this PR do?

Migrate from home made code to parse Gitlab to Gitlab lint endpoint
It should fix a bug in the flakes finder

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@github-actions github-actions bot added team/agent-devx-infra Deprecated, please use agent-devx instead team/agent-devx-loops Deprecated, please use agent-devx instead labels Jul 3, 2024
@KevinFairise2 KevinFairise2 force-pushed the kfairise/testwasher-migrate-parsing branch from f5927b3 to 316ce65 Compare July 3, 2024 09:16
@KevinFairise2 KevinFairise2 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 3, 2024
@KevinFairise2 KevinFairise2 marked this pull request as ready for review July 3, 2024 09:20
@KevinFairise2 KevinFairise2 requested review from a team as code owners July 3, 2024 09:20
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jul 3, 2024

[Fast Unit Tests Report]

On pipeline 38231510 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Jul 3, 2024

Regression Detector

Regression Detector Results

Run ID: d985d691-0c27-4793-9991-a426301c84ba Metrics dashboard Target profiles

Baseline: d41ff64
Comparison: 316ce65

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
idle memory utilization +0.73 [+0.69, +0.77] Logs
pycheck_1000_100byte_tags % cpu utilization +0.68 [-3.98, +5.34] Logs
tcp_syslog_to_blackhole ingress throughput +0.42 [-12.47, +13.32] Logs
otel_to_otel_logs ingress throughput +0.30 [-0.51, +1.11] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
basic_py_check % cpu utilization -0.68 [-3.31, +1.94] Logs
file_tree memory utilization -0.79 [-0.90, -0.67] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.84 [-1.71, +0.03] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 3, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit b0622f4 into main Jul 3, 2024
@dd-mergequeue dd-mergequeue bot deleted the kfairise/testwasher-migrate-parsing branch July 3, 2024 11:37
@github-actions github-actions bot added this to the 7.56.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra Deprecated, please use agent-devx instead team/agent-devx-loops Deprecated, please use agent-devx instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants