Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky Windows health e2e tests #25049

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Kaderinho
Copy link
Contributor

@Kaderinho Kaderinho commented Apr 24, 2024

What does this PR do?

Disable flaky test

Motivation

Avoid failures on main while waiting for a fix

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
@Kaderinho Kaderinho added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog labels Apr 24, 2024
@Kaderinho Kaderinho marked this pull request as ready for review April 24, 2024 09:25
@Kaderinho Kaderinho requested a review from a team as a code owner April 24, 2024 09:25
Copy link
Member

@pgimalac pgimalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM until we find a way to fix it

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 32792323 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=32792323 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2024

Regression Detector

Regression Detector Results

Run ID: ffbb30e3-1717-4cf2-af7e-ae548758a64e
Baseline: 995481d
Comparison: 629b0b9

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -18.53 [-22.71, -14.35]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +7.44 [-14.22, +29.10]
pycheck_1000_100byte_tags % cpu utilization +3.73 [-1.24, +8.69]
basic_py_check % cpu utilization +1.70 [-0.97, +4.36]
uds_dogstatsd_to_api_cpu % cpu utilization +0.60 [-2.35, +3.54]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.02]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.04, +0.05]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
process_agent_standard_check_with_stats memory utilization -0.02 [-0.07, +0.03]
idle memory utilization -0.08 [-0.12, -0.04]
otel_to_otel_logs ingress throughput -0.10 [-0.48, +0.28]
process_agent_real_time_mode memory utilization -0.61 [-0.66, -0.57]
process_agent_standard_check memory utilization -3.28 [-3.52, -3.05]
file_to_blackhole % cpu utilization -18.53 [-22.71, -14.35]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@Kaderinho
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit c1408f9 into main Apr 24, 2024
211 of 212 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nicolas.guerguadj/temporary-disable-health-test branch April 24, 2024 13:08
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 24, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
Signed-off-by: Nicolas Guerguadj <nicolas.guerguadj@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants