-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix utility for getting the current Git reference #23015
Conversation
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: a4e01a60-c009-40d9-a02c-b23967cb6eed Performance changes are noted in the perf column of each table:
Experiments with missing or malformed data
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +0.07 | [-6.48, +6.62] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.41 | [+0.35, +0.47] |
➖ | file_tree | memory utilization | +0.37 | [+0.30, +0.45] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.37 | [-1.07, +1.80] |
➖ | file_to_blackhole | % cpu utilization | +0.07 | [-6.48, +6.62] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.07 | [+0.04, +0.10] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.01, +0.01] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | process_agent_standard_check | memory utilization | -0.03 | [-0.07, +0.01] |
➖ | trace_agent_json | ingress throughput | -0.03 | [-0.06, -0.00] |
➖ | otel_to_otel_logs | ingress throughput | -0.26 | [-0.89, +0.37] |
➖ | process_agent_real_time_mode | memory utilization | -0.28 | [-0.31, -0.25] |
➖ | idle | memory utilization | -0.50 | [-0.53, -0.47] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
||
# https://circleci.com/docs/variables/#built-in-environment-variables | ||
if running_in_circleci(): | ||
return os.environ.get("CIRCLE_TAG") or os.environ["CIRCLE_BRANCH"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return os.environ.get("CIRCLE_TAG") or os.environ["CIRCLE_BRANCH"] | |
return os.environ["CIRCLE_BRANCH"] |
I'm not sure we are running for tags on circleci, only on branches. But this is probably harmless
Motivation
GitLab always checks out in a detached HEAD state