Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utility for getting the current Git reference #23015

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix utility for getting the current Git reference #23015

merged 3 commits into from
Feb 21, 2024

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 20, 2024

Motivation

GitLab always checks out in a detached HEAD state

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: a4e01a60-c009-40d9-a02c-b23967cb6eed
Baseline: 8a92821
Comparison: f69bffd
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.07 [-6.48, +6.62]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.35, +0.47]
file_tree memory utilization +0.37 [+0.30, +0.45]
uds_dogstatsd_to_api_cpu % cpu utilization +0.37 [-1.07, +1.80]
file_to_blackhole % cpu utilization +0.07 [-6.48, +6.62]
process_agent_standard_check_with_stats memory utilization +0.07 [+0.04, +0.10]
trace_agent_msgpack ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_standard_check memory utilization -0.03 [-0.07, +0.01]
trace_agent_json ingress throughput -0.03 [-0.06, -0.00]
otel_to_otel_logs ingress throughput -0.26 [-0.89, +0.37]
process_agent_real_time_mode memory utilization -0.28 [-0.31, -0.25]
idle memory utilization -0.50 [-0.53, -0.47]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".


# https://circleci.com/docs/variables/#built-in-environment-variables
if running_in_circleci():
return os.environ.get("CIRCLE_TAG") or os.environ["CIRCLE_BRANCH"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return os.environ.get("CIRCLE_TAG") or os.environ["CIRCLE_BRANCH"]
return os.environ["CIRCLE_BRANCH"]

I'm not sure we are running for tags on circleci, only on branches. But this is probably harmless

@amenasria amenasria merged commit 7b4702d into main Feb 21, 2024
164 checks passed
@amenasria amenasria deleted the ofek/utils branch February 21, 2024 12:59
@github-actions github-actions bot added this to the 7.52.0 milestone Feb 21, 2024
@pducolin pducolin added the qa/no-code-change No code change in Agent code requiring validation label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants