Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutex state to getFreePort testutil #22080

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

FlorianVeaux
Copy link
Member

Been seeing some flaky tests lately

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e09db5b4-6ee3-4380-9bbd-102126f06e51
Baseline: 043c9ac
Comparison: 393f5e2
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.26 [+0.14, +0.39]
idle memory utilization +0.03 [-0.01, +0.07]
file_to_blackhole % cpu utilization -1.12 [-7.65, +5.41]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +0.53 [-0.19, +1.24]
process_agent_standard_check_with_stats memory utilization +0.48 [+0.42, +0.55]
tcp_syslog_to_blackhole ingress throughput +0.37 [+0.31, +0.44]
file_tree memory utilization +0.26 [+0.14, +0.39]
trace_agent_msgpack ingress throughput +0.03 [+0.01, +0.05]
idle memory utilization +0.03 [-0.01, +0.07]
process_agent_standard_check memory utilization +0.01 [-0.06, +0.08]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.05, +0.05]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.03, +0.03]
trace_agent_json ingress throughput -0.04 [-0.07, -0.01]
process_agent_real_time_mode memory utilization -0.40 [-0.46, -0.35]
file_to_blackhole % cpu utilization -1.12 [-7.65, +5.41]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@FlorianVeaux FlorianVeaux merged commit a27fe22 into main Jan 16, 2024
161 of 162 checks passed
@FlorianVeaux FlorianVeaux deleted the flo/improve_getfreeport branch January 16, 2024 10:33
@FlorianVeaux FlorianVeaux added the qa/no-code-change No code change in Agent code requiring validation label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants